* Re: [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There is no 'C-; '.
[not found] ` <E1YPH4o-0006wC-Cj@vcs.savannah.gnu.org>
@ 2015-02-23 1:55 ` Stefan Monnier
2015-02-23 2:03 ` Dmitry Gutov
0 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2015-02-23 1:55 UTC (permalink / raw)
To: emacs-devel; +Cc: Paul Eggert
> For now, make do with 'M-;'; this allows 'make bootstrap' to work.
Huh, no, M-; should still be bound to comment-dwim,
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There is no 'C-; '.
2015-02-23 1:55 ` [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There is no 'C-; ' Stefan Monnier
@ 2015-02-23 2:03 ` Dmitry Gutov
2015-02-23 4:32 ` Stefan Monnier
2015-02-23 4:42 ` Artur Malabarba
0 siblings, 2 replies; 9+ messages in thread
From: Dmitry Gutov @ 2015-02-23 2:03 UTC (permalink / raw)
To: Stefan Monnier, emacs-devel; +Cc: Paul Eggert
On 02/23/2015 03:55 AM, Stefan Monnier wrote:
> Huh, no, M-; should still be bound to comment-dwim,
That was also my first reaction. But the actual binding it ended up with
is `C-x M-;'.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There is no 'C-; '.
2015-02-23 2:03 ` Dmitry Gutov
@ 2015-02-23 4:32 ` Stefan Monnier
2015-02-23 4:42 ` Artur Malabarba
1 sibling, 0 replies; 9+ messages in thread
From: Stefan Monnier @ 2015-02-23 4:32 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: Paul Eggert, emacs-devel
>> Huh, no, M-; should still be bound to comment-dwim,
> That was also my first reaction. But the actual binding it ended up with is
> `C-x M-;'.
Duh, right!
Stefan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There is no 'C-; '.
2015-02-23 2:03 ` Dmitry Gutov
2015-02-23 4:32 ` Stefan Monnier
@ 2015-02-23 4:42 ` Artur Malabarba
2015-02-23 6:04 ` bug#19826: " Paul Eggert
` (2 more replies)
1 sibling, 3 replies; 9+ messages in thread
From: Artur Malabarba @ 2015-02-23 4:42 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: Paul Eggert, Stefan Monnier, emacs-devel
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
The actual binding was supposed to be C-x C-;. The problem with bootstrap
surprises me, but I guess it must be something in the order that files are
loaded.
Thanks a lot for providing a quick fix. I won't be able pick up a computer
for several days now. I'll look into this when I can.
On Feb 22, 2015 11:03 PM, "Dmitry Gutov" <dgutov@yandex.ru> wrote:
> On 02/23/2015 03:55 AM, Stefan Monnier wrote:
>
> Huh, no, M-; should still be bound to comment-dwim,
>>
>
> That was also my first reaction. But the actual binding it ended up with
> is `C-x M-;'.
>
>
[-- Attachment #2: Type: text/html, Size: 964 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#19826: [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There is no 'C-; '.
2015-02-23 4:42 ` Artur Malabarba
@ 2015-02-23 6:04 ` Paul Eggert
2015-02-23 7:32 ` Artur Malabarba
2015-02-23 11:41 ` Andreas Schwab
2015-02-23 12:13 ` Nicolas Richard
2 siblings, 1 reply; 9+ messages in thread
From: Paul Eggert @ 2015-02-23 6:04 UTC (permalink / raw)
To: bruce.connor.am, Dmitry Gutov; +Cc: 19826-done
[-- Attachment #1: Type: text/plain, Size: 423 bytes --]
Artur Malabarba wrote:
> The actual binding was supposed to be C-x C-;. The problem with bootstrap
> surprises me, but I guess it must be something in the order that files are
> loaded.
It's because if you try to evaluate the string "\C-;", Emacs throws (error
"Invalid modifier in string"). I installed the attached patch to use the
keybinding that you wanted. This should fix the bug, so I'm closing the bug report.
[-- Attachment #2: 0001-Fix-the-desired-binding-for-comment-line.patch --]
[-- Type: text/x-patch, Size: 1387 bytes --]
From f03d9e2d77771d10a61db329091dc6bc7f547bdf Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 22 Feb 2015 22:00:01 -0800
Subject: [PATCH] Fix the desired binding for comment-line
* bindings.el (ctl-x-map): Use [?\C-\;] to get the desired binding.
Fixes: bug#19826
---
lisp/ChangeLog | 6 ++++++
lisp/bindings.el | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 6352d77..c1fb869 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,9 @@
+2015-02-23 Paul Eggert <eggert@cs.ucla.edu>
+
+ Fix the desired binding for comment-line
+ * bindings.el (ctl-x-map): Use [?\C-\;] to get the desired binding.
+ Fixes: bug#19826
+
2015-02-23 Stefan Monnier <monnier@iro.umontreal.ca>
* emacs-lisp/macroexp.el (macroexp-parse-body): Handle cl-declare
diff --git a/lisp/bindings.el b/lisp/bindings.el
index a1f0d98..b658914 100644
--- a/lisp/bindings.el
+++ b/lisp/bindings.el
@@ -1130,7 +1130,7 @@ if `inhibit-field-text-motion' is non-nil."
(define-key esc-map "j" 'indent-new-comment-line)
(define-key esc-map "\C-j" 'indent-new-comment-line)
(define-key ctl-x-map ";" 'comment-set-column)
-(define-key ctl-x-map "\M-;" 'comment-line)
+(define-key ctl-x-map [?\C-\;] 'comment-line)
(define-key ctl-x-map "f" 'set-fill-column)
(define-key ctl-x-map "$" 'set-selective-display)
--
2.1.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* bug#19826: [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There is no 'C-; '.
2015-02-23 6:04 ` bug#19826: " Paul Eggert
@ 2015-02-23 7:32 ` Artur Malabarba
0 siblings, 0 replies; 9+ messages in thread
From: Artur Malabarba @ 2015-02-23 7:32 UTC (permalink / raw)
To: Paul Eggert; +Cc: 19826-done
[-- Attachment #1: Type: text/plain, Size: 547 bytes --]
Yes, that looks fine. Thanks again.!
On Feb 23, 2015 3:04 AM, "Paul Eggert" <eggert@cs.ucla.edu> wrote:
> Artur Malabarba wrote:
>
>> The actual binding was supposed to be C-x C-;. The problem with bootstrap
>> surprises me, but I guess it must be something in the order that files are
>> loaded.
>>
>
> It's because if you try to evaluate the string "\C-;", Emacs throws (error
> "Invalid modifier in string"). I installed the attached patch to use the
> keybinding that you wanted. This should fix the bug, so I'm closing the
> bug report.
>
[-- Attachment #2: Type: text/html, Size: 942 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There is no 'C-; '.
2015-02-23 4:42 ` Artur Malabarba
2015-02-23 6:04 ` bug#19826: " Paul Eggert
@ 2015-02-23 11:41 ` Andreas Schwab
2015-02-23 12:13 ` Nicolas Richard
2 siblings, 0 replies; 9+ messages in thread
From: Andreas Schwab @ 2015-02-23 11:41 UTC (permalink / raw)
To: Artur Malabarba; +Cc: Paul Eggert, emacs-devel, Stefan Monnier, Dmitry Gutov
Artur Malabarba <bruce.connor.am@gmail.com> writes:
> The actual binding was supposed to be C-x C-;. The problem with bootstrap
> surprises me,
"\C-;" is not a valid syntax.
ELISP> "\C-;"
*** Read error *** Invalid modifier in string
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There is no 'C-; '.
2015-02-23 4:42 ` Artur Malabarba
2015-02-23 6:04 ` bug#19826: " Paul Eggert
2015-02-23 11:41 ` Andreas Schwab
@ 2015-02-23 12:13 ` Nicolas Richard
2015-02-23 12:42 ` Artur Malabarba
2 siblings, 1 reply; 9+ messages in thread
From: Nicolas Richard @ 2015-02-23 12:13 UTC (permalink / raw)
To: Artur Malabarba; +Cc: Paul Eggert, emacs-devel, Stefan Monnier, Dmitry Gutov
Hello,
Artur Malabarba <bruce.connor.am@gmail.com> writes:
> The actual binding was supposed to be C-x C-;. The problem with
> bootstrap surprises me, but I guess it must be something in the order
> that files are loaded.
"\C-a" is a string with one character. It is just a fancy way of doing
(string 1). But \C-\; doesn't exist as a character.
As suggested in (info "(elisp) Changing Key Bindings"), we could use:
(define-key ctl-x-map [(control ?\;)] 'comment-line)
Or also the (IMHO) uglier version:
(define-key ctl-x-map [?\C-\;] 'comment-line)
--
Nicolas Richard
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There is no 'C-; '.
2015-02-23 12:13 ` Nicolas Richard
@ 2015-02-23 12:42 ` Artur Malabarba
0 siblings, 0 replies; 9+ messages in thread
From: Artur Malabarba @ 2015-02-23 12:42 UTC (permalink / raw)
To: Nicolas Richard; +Cc: Paul Eggert, Dmitry Gutov, Stefan Monnier, emacs-devel
[-- Attachment #1: Type: text/plain, Size: 136 bytes --]
> Or also the (IMHO) uglier version:
> (define-key ctl-x-map [?\C-\;] 'comment-line)
Yes, and it seems Paul already pushed this.
Cheers
[-- Attachment #2: Type: text/html, Size: 182 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-02-23 12:42 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20150221205502.26624.18158@vcs.savannah.gnu.org>
[not found] ` <E1YPH4o-0006wC-Cj@vcs.savannah.gnu.org>
2015-02-23 1:55 ` [Emacs-diffs] master 1cb3428: * bindings.el (ctl-x-map): There is no 'C-; ' Stefan Monnier
2015-02-23 2:03 ` Dmitry Gutov
2015-02-23 4:32 ` Stefan Monnier
2015-02-23 4:42 ` Artur Malabarba
2015-02-23 6:04 ` bug#19826: " Paul Eggert
2015-02-23 7:32 ` Artur Malabarba
2015-02-23 11:41 ` Andreas Schwab
2015-02-23 12:13 ` Nicolas Richard
2015-02-23 12:42 ` Artur Malabarba
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.