From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23458: [PATCH] Support completion of HTML tags in CSS selectors Date: Thu, 05 May 2016 11:02:28 -0400 Message-ID: References: <1462451565.2892.0@smtp.gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1462460688 29993 80.91.229.3 (5 May 2016 15:04:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 5 May 2016 15:04:48 +0000 (UTC) Cc: 23458@debbugs.gnu.org, dgutov@yandex.ru To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 05 17:04:35 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ayKpN-0007x4-S5 for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 May 2016 17:04:34 +0200 Original-Received: from localhost ([::1]:54001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayKpJ-000824-Ub for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 May 2016 11:04:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41632) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayKp7-0007g8-Qw for bug-gnu-emacs@gnu.org; Thu, 05 May 2016 11:04:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayKov-0003ct-RN for bug-gnu-emacs@gnu.org; Thu, 05 May 2016 11:04:12 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayKov-0003aJ-OQ for bug-gnu-emacs@gnu.org; Thu, 05 May 2016 11:04:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ayKos-0005FJ-5q for bug-gnu-emacs@gnu.org; Thu, 05 May 2016 11:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 May 2016 15:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23458 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, Dmitry Gutov Original-Received: via spool by submit@debbugs.gnu.org id=B.146246060820124 (code B ref -1); Thu, 05 May 2016 15:04:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 May 2016 15:03:28 +0000 Original-Received: from localhost ([127.0.0.1]:40320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ayKoK-0005EV-Lm for submit@debbugs.gnu.org; Thu, 05 May 2016 11:03:28 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ayKoJ-0005EH-0F for submit@debbugs.gnu.org; Thu, 05 May 2016 11:03:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayKo4-00036v-9E for submit@debbugs.gnu.org; Thu, 05 May 2016 11:03:18 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:44796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayKo4-00035j-6D for submit@debbugs.gnu.org; Thu, 05 May 2016 11:03:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40893) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayKns-0005WP-5d for bug-gnu-emacs@gnu.org; Thu, 05 May 2016 11:03:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayKnd-0002vV-J4 for bug-gnu-emacs@gnu.org; Thu, 05 May 2016 11:02:52 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:35734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayKnd-0002qS-Eo for bug-gnu-emacs@gnu.org; Thu, 05 May 2016 11:02:45 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u45F2TqA028832; Thu, 5 May 2016 11:02:29 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id E7DEC600E9; Thu, 5 May 2016 11:02:28 -0400 (EDT) In-Reply-To: <1462451565.2892.0@smtp.gmail.com> ("Simen =?UTF-8?Q?Heggest=C3=B8yl?="'s message of "Thu, 05 May 2016 14:32:45 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5663=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5663> : inlines <4764> : streams <1630449> : uri <2203735> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117843 Archived-At: > @@ -747,7 +749,7 @@ css--complete-property > (let ((start (point))) > (skip-chars-backward " \t\r\n") > (when (memq (char-before) '(?\{ ?\;)) > - (list start pos css-property-ids)))))) > + (list start pos css-property-ids :exclusive 'no)))))) > > (defun css--complete-bang-rule () > "Complete bang-rule at point." It'd be better to avoid the :exclusive thingy, and use something like completion-table-merge instead. :exclusive basically prevents any completion style other than prefix completion, so it's better avoid it when possible. This said, it's not a real objection. Stefan