all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: two likely bugs with qualified methods
Date: Fri, 15 Jul 2016 09:31:38 -0400	[thread overview]
Message-ID: <jwvr3avm3oe.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 57889DE1.4050306@gmail.com

>   (declare (doc-string 3) (indent 2)
>            (debug
>             (&define                    ; this means we are defining something
>              [&or name ("setf" :name setf name)]
>              ;; ^^ This is the methods symbol
>              [ &optional keywordp ]     ; this is key :before etc
>              list                       ; arguments
>              [ &optional stringp ]      ; documentation string
>              def-body)))                ; part to be debugged

> (indent 2) could be changed to (indent defun);

That might work, indeed.

>  the debug spec could probably be fixed by using one of the edebug
>  specs in cl-macs, such as `cl-lambda-list'.

I don't think this will help.  The problem is that the qualifiers are
matched by [ &optional keywordp ] which was sufficient for EIEIO's
defmethod, but not for cl-defmethod (which accepts the more general
Common Lisp form of qualifiers, i.e. any sequence of non-lists).


        Stefan




  reply	other threads:[~2016-07-15 13:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15  7:11 two likely bugs with qualified methods Eric Abrahamsen
2016-07-15  8:25 ` Clément Pit--Claudel
2016-07-15 13:31   ` Stefan Monnier [this message]
2016-07-15 16:04   ` Eric Abrahamsen
2016-07-15 13:27 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr3avm3oe.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.