From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: npostavs@users.sourceforge.net
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
27016@debbugs.gnu.org,
Rafael D Sorkin <rsorkin@perimeterinstitute.ca>
Subject: bug#27016: possible bug in `defsetf'
Date: Thu, 13 Jul 2017 10:25:38 -0400 [thread overview]
Message-ID: <jwvr2xke824.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87a849djvp.fsf@users.sourceforge.net> (npostavs's message of "Thu, 13 Jul 2017 00:46:18 -0400")
> Oh, I think I get it now.
Looks about right. A few comments below.
Stefan
> @@ -4577,6 +4582,7 @@ (byte-defop-compiler-1 defvar)
> (byte-defop-compiler-1 defconst byte-compile-defvar)
> (byte-defop-compiler-1 autoload)
> (byte-defop-compiler-1 lambda byte-compile-lambda-form)
> +(byte-defop-compiler-1 function-put)
>
> ;; If foo.el declares `toto' as obsolete, it is likely that foo.el will
> ;; actually use `toto' in order for this obsolete variable to still work
I know it's not how it's done everywhere now, but I like to put the
byte-defop-compiler-1 next to the handler function.
> @@ -4725,6 +4731,18 @@ (put 'make-variable-buffer-local
> 'byte-hunk-handler 'byte-compile-form-make-variable-buffer-local)
> (defun byte-compile-form-make-variable-buffer-local (form)
> (byte-compile-keep-pending form 'byte-compile-normal-call))
> +
> +(defun byte-compile-function-put (form)
> + (pcase form
> + (`(,_ (,(or 'quote 'function) ,(and fun (guard (symbolp fun))))
> + ',prop ,(or `#',value (and value (guard (functionp value)))))
The value doesn't have to be `functionp` (it is in the case of
gv-expander, but it depends on the property).
> + (let ((fplist (assq fun byte-compile-plist-environment)))
> + (if fplist
> + (setcdr fplist (plist-put (cdr fplist) prop value))
> + (push (cons fun (list prop value))
> + byte-compile-plist-environment)))))
I'd just unconditionally use `push`:
(push (cons fun `(,prop ,value . ,fplist))
byte-compile-plist-environment)))))
next prev parent reply other threads:[~2017-07-13 14:25 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 6:39 bug#27016: possible bug in `defsetf' Rafael D Sorkin
2017-05-22 12:11 ` npostavs
2017-05-22 20:25 ` Rafael D Sorkin
2017-05-22 21:18 ` npostavs
2017-05-22 23:10 ` Michael Heerdegen
2017-05-22 23:23 ` npostavs
2017-05-23 0:45 ` Michael Heerdegen
2017-05-23 0:51 ` npostavs
2017-05-23 1:18 ` Michael Heerdegen
2017-05-22 22:03 ` Rafael D Sorkin
2017-05-22 23:15 ` npostavs
2017-05-24 4:52 ` Rafael D Sorkin
2017-05-24 22:51 ` Michael Heerdegen
2017-05-25 1:50 ` npostavs
2017-05-25 4:59 ` Rafael D Sorkin
2017-05-25 5:01 ` Rafael D Sorkin
2017-05-25 10:38 ` npostavs
2017-05-25 20:26 ` Michael Heerdegen
2017-05-25 20:42 ` Noam Postavsky
2017-05-25 21:31 ` Michael Heerdegen
2017-05-25 23:03 ` npostavs
2017-05-25 23:40 ` Michael Heerdegen
2017-05-26 3:50 ` Stefan Monnier
2017-05-26 22:51 ` npostavs
2017-05-28 20:45 ` Stefan Monnier
2017-07-02 20:47 ` npostavs
2017-07-03 11:25 ` Michael Heerdegen
2017-07-09 20:13 ` npostavs
2017-07-10 0:26 ` Michael Heerdegen
2017-07-11 1:45 ` npostavs
2017-07-11 16:21 ` Stefan Monnier
2017-07-12 0:55 ` npostavs
2017-07-12 2:01 ` Stefan Monnier
2017-07-13 4:46 ` npostavs
2017-07-13 14:25 ` Stefan Monnier [this message]
2017-07-14 0:39 ` npostavs
2017-07-14 3:48 ` Stefan Monnier
2017-07-14 4:32 ` Stefan Monnier
2017-07-15 14:51 ` npostavs
2017-07-16 1:03 ` Stefan Monnier
2017-08-08 1:18 ` npostavs
2017-05-26 5:05 ` Rafael D Sorkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr2xke824.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=27016@debbugs.gnu.org \
--cc=michael_heerdegen@web.de \
--cc=npostavs@users.sourceforge.net \
--cc=rsorkin@perimeterinstitute.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.