From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 551594e: Add indent spec to easy-mmode macros Date: Thu, 28 Sep 2017 08:38:04 -0400 Message-ID: References: <20170928115443.21221.85942@vcs0.savannah.gnu.org> <20170928115444.536A4203B7@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1506602299 11394 195.159.176.226 (28 Sep 2017 12:38:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 28 Sep 2017 12:38:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: Mark Oteiza To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 28 14:38:16 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dxY50-0002cy-9y for ged-emacs-devel@m.gmane.org; Thu, 28 Sep 2017 14:38:14 +0200 Original-Received: from localhost ([::1]:59109 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxY57-0005gD-Ig for ged-emacs-devel@m.gmane.org; Thu, 28 Sep 2017 08:38:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dxY50-0005g6-Ql for emacs-devel@gnu.org; Thu, 28 Sep 2017 08:38:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dxY4x-0003p1-Im for emacs-devel@gnu.org; Thu, 28 Sep 2017 08:38:14 -0400 Original-Received: from pmta11.teksavvy.com ([76.10.157.34]:26436) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1dxY4x-0003oP-DP for emacs-devel@gnu.org; Thu, 28 Sep 2017 08:38:11 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2EGEgDr68xZ/1V13mhdHQEFAQsBg1yBU?= =?us-ascii?q?okshgaOawGBdS8BmA0KhTUEAgKEH1gBAgEBAQEBAgNoKIUZAQQBViMFCws0EhQ?= =?us-ascii?q?YDYpgCKkbiwEBAQEBBgImgyuFPYMohVCFJwWhKJZbAYlOhzyVTYE5WIEOMiEIM?= =?us-ascii?q?ogCJIk7AQEB?= X-IPAS-Result: =?us-ascii?q?A2EGEgDr68xZ/1V13mhdHQEFAQsBg1yBUokshgaOawGBdS8?= =?us-ascii?q?BmA0KhTUEAgKEH1gBAgEBAQEBAgNoKIUZAQQBViMFCws0EhQYDYpgCKkbiwEBA?= =?us-ascii?q?QEBBgImgyuFPYMohVCFJwWhKJZbAYlOhzyVTYE5WIEOMiEIMogCJIk7AQEB?= X-IronPort-AV: E=Sophos;i="5.42,450,1500955200"; d="scan'208";a="5235720" Original-Received: from 104-222-117-85.cpe.teksavvy.com (HELO ceviche.home) ([104.222.117.85]) by smtp.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Sep 2017 08:38:04 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 9704466268; Thu, 28 Sep 2017 08:38:04 -0400 (EDT) In-Reply-To: <20170928115444.536A4203B7@vcs0.savannah.gnu.org> (Mark Oteiza's message of "Thu, 28 Sep 2017 07:54:43 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 76.10.157.34 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218849 Archived-At: > Add indent spec to easy-mmode macros > Ideally these macros should expand to the proper code instead of > relegating all the work to a function call. Not sure why this comment is in the commit message, but FWIW, I tend to disagree: it's usually preferable to keep the macro part to a minimum (handling the syntax), and to keep as much as possible in functions. There's no hard&fast rule, tho. Stefan