From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Lifting all buffer restrictions in indentation functions Date: Fri, 08 Dec 2017 12:03:45 -0500 Message-ID: References: <83wp1xupqs.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1512752788 29172 195.159.176.226 (8 Dec 2017 17:06:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 8 Dec 2017 17:06:28 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 08 18:06:24 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eNM6R-0007RC-AM for ged-emacs-devel@m.gmane.org; Fri, 08 Dec 2017 18:06:23 +0100 Original-Received: from localhost ([::1]:38311 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNM6Y-0004u4-K0 for ged-emacs-devel@m.gmane.org; Fri, 08 Dec 2017 12:06:30 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58463) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eNM46-0002qX-8Y for emacs-devel@gnu.org; Fri, 08 Dec 2017 12:03:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eNM41-0002cI-B4 for emacs-devel@gnu.org; Fri, 08 Dec 2017 12:03:58 -0500 Original-Received: from [195.159.176.226] (port=54629 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eNM41-0002c8-3m for emacs-devel@gnu.org; Fri, 08 Dec 2017 12:03:53 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1eNM3q-0003DA-Vt for emacs-devel@gnu.org; Fri, 08 Dec 2017 18:03:42 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 22 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:hb2ITr1EVkhSRR/JgoT1ZZiI4Qo= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220795 Archived-At: > (save-excursion ^^^^^^^^^ restriction > (narrow-to-region START END) > (indent-for-tab-command)) While such code might exist somewhere [tho most likely calling indent-according-to-mode instead], the reasons why I think breaking such code is the right thing are: - it's very rare - it should be easy to change this code so it works with the new (and the old) convention, by replacing (indent-according-to-mode) with (funcall indent-line-function). - the reverse problem (i.e. where the restriction is currently obeyed while it shouldn't) is much more common. IOW the change could introduce breakage, but in my opinion, it will correct many more situations than it breaks, and those that it breaks are easy to fix. Stefan