From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Noam Postavsky <npostavs@gmail.com>
Cc: Aidan Kehoe <kehoea@parhasard.net>, 31792@debbugs.gnu.org
Subject: bug#31792: 27.0.50; Regression in #'labels, recent versions
Date: Wed, 13 Jun 2018 09:16:01 -0400 [thread overview]
Message-ID: <jwvr2labzhg.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <87k1r3y5m2.fsf@gmail.com> (Noam Postavsky's message of "Tue, 12 Jun 2018 18:58:29 -0400")
> diff --git a/lisp/emacs-lisp/cl.el b/lisp/emacs-lisp/cl.el
> index d53c8e0bbc..85deb8cb4f 100644
> --- a/lisp/emacs-lisp/cl.el
> +++ b/lisp/emacs-lisp/cl.el
> @@ -466,8 +466,9 @@ labels
> (push var sets)
> (push (cons (car binding)
> `(lambda (&rest cl-labels-args)
> - (cl-list* 'funcall ',var
> - cl-labels-args)))
> + (if (eq (car cl-labels-args) cl--labels-magic)
> + (list cl--labels-magic ',var)
> + (cl-list* 'funcall ',var cl-labels-args))))
> newenv)))
> (macroexpand-all `(lexical-let ,vars (setq ,@sets) ,@body) newenv)))
Looks good, but please add a comment before the call to macroexpand-all
reminding that lexical-let installs a macroexpander for `function` that
ends up calling cl--labels-convert.
Stefan
next prev parent reply other threads:[~2018-06-13 13:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 23:11 bug#31792: 27.0.50; Regression in #'labels, recent versions Aidan Kehoe
2018-06-11 23:31 ` Noam Postavsky
2018-06-12 22:58 ` Noam Postavsky
2018-06-13 13:16 ` Stefan Monnier [this message]
2018-06-14 3:24 ` Noam Postavsky
2018-06-14 3:32 ` Stefan Monnier
2018-06-14 4:13 ` Noam Postavsky
2018-06-14 18:05 ` Stefan Monnier
2018-06-20 0:08 ` Noam Postavsky
[not found] ` <mailman.1699.1528759928.1292.bug-gnu-emacs@gnu.org>
2018-06-13 16:57 ` Alan Mackenzie
2018-06-13 17:03 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr2labzhg.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=31792@debbugs.gnu.org \
--cc=kehoea@parhasard.net \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.