all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* When calling defuns is a Bad Thing.
@ 2018-10-21 16:41 Alan Mackenzie
  2018-10-21 18:07 ` Stefan Monnier
  0 siblings, 1 reply; 4+ messages in thread
From: Alan Mackenzie @ 2018-10-21 16:41 UTC (permalink / raw)
  To: emacs-devel; +Cc: Gemini Lasswell

Hello, Emacs.

Calling defuns (as opposed to primitives) from edebug is a bad idea,
unless those defuns are also defined in edebug.el.

The reason is that edebug.el exists to debug these defuns, and if the
edebug engine uses a defun which happens to be instrumented, Emacs will
(probably) lock up.

For the same reason, edebug should probably avoid using "complicated"
macros, such as the pcase family and cl-... because it is difficult to be
sure that their expansions will not introduce non-primitives into the
code.

Currently, edebug calls (at least) one-window-p and walk-windows, which
it shouldn't.  Possibly, it should define edebug- versions of them.
There are also quite a few uses of cl-... which is somewhat worrying.

At the very least, edebug should NOT replace its own edebug-pop-to-buffer
with pop-to-buffer, as has been suggested in a comment.

Comments?

-- 
Alan Mackenzie (Nuremberg, Germany).



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-10-22 15:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-21 16:41 When calling defuns is a Bad Thing Alan Mackenzie
2018-10-21 18:07 ` Stefan Monnier
2018-10-22 14:06   ` Alan Mackenzie
2018-10-22 15:25     ` Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.