From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: new-flex-completion-style Date: Mon, 18 Feb 2019 18:35:26 -0500 Message-ID: References: <20190202232827.27331.87300@vcs0.savannah.gnu.org> <20190202232828.4AE452159A@vcs0.savannah.gnu.org> <87lg2mynrg.fsf@gmail.com> <87wolwvn8k.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="165888"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 19 00:36:05 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gvsSD-000h2i-Bx for ged-emacs-devel@m.gmane.org; Tue, 19 Feb 2019 00:36:05 +0100 Original-Received: from localhost ([127.0.0.1]:38289 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvsSC-0007Ly-Bs for ged-emacs-devel@m.gmane.org; Mon, 18 Feb 2019 18:36:04 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvsRg-0007B8-Qo for emacs-devel@gnu.org; Mon, 18 Feb 2019 18:35:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gvsRf-0004su-1V for emacs-devel@gnu.org; Mon, 18 Feb 2019 18:35:32 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:58551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gvsRd-0004iG-Dl for emacs-devel@gnu.org; Mon, 18 Feb 2019 18:35:30 -0500 Original-Received: from ceviche.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x1INZQuE010045; Mon, 18 Feb 2019 18:35:26 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id 28184661E8; Mon, 18 Feb 2019 18:35:26 -0500 (EST) In-Reply-To: <87wolwvn8k.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Mon, 18 Feb 2019 20:46:19 +0000") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6485=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6485> : inlines <7018> : streams <1813436> : uri <2798500> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233447 Archived-At: > @@ -1801,7 +1801,9 @@ If FLAG is nil, invoke `try-completion'; if it is t, invoke > else if (EQ (flag, Qlambda)) > return Ftest_completion (string, Vbuffer_alist, predicate); > else if (EQ (flag, Qmetadata)) > - return list2 (Qmetadata, Fcons (Qcategory, Qbuffer)); > + return list3 (Qmetadata, > + Fcons (Qcategory, Qbuffer), > + Fcons (Qcycle_sort_function, Qidentity)); > else > return Qnil; > } That easy, huh? > * lisp/minibuffer.el (completion-all-sorted-completions): Don't > re-sort if completion table has cycle-sort-function. I think a more precise description would be that cycle-sort-function now also overrides the use of minibuffer-history-variable. [ "Don't re-sort" sounds like a mere optimization rather than a change of semantics. ] Other than that, LGTM, Stefan