From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 58a3c54: Avoid using string-make-unibyte in select.el Date: Sat, 22 Jun 2019 09:26:38 -0400 Message-ID: References: <20190622083524.20617.42423@vcs0.savannah.gnu.org> <20190622083525.F1CA5209DE@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="40799"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Eli Zaretskii To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 22 15:27:34 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1heg3K-000AVN-5C for ged-emacs-devel@m.gmane.org; Sat, 22 Jun 2019 15:27:34 +0200 Original-Received: from localhost ([::1]:40784 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heg3J-0002Mz-70 for ged-emacs-devel@m.gmane.org; Sat, 22 Jun 2019 09:27:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43321) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1heg2Y-0002Mg-9z for emacs-devel@gnu.org; Sat, 22 Jun 2019 09:26:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1heg2X-0004tK-Gh for emacs-devel@gnu.org; Sat, 22 Jun 2019 09:26:46 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:43071) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1heg2V-0004ka-NS; Sat, 22 Jun 2019 09:26:43 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E223C81198; Sat, 22 Jun 2019 09:26:40 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5B487810E7; Sat, 22 Jun 2019 09:26:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1561209999; bh=pRoGlEhEV1gmpcieQqlDZsHLb02fr8HQsTPX4suwC6E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=adlJqJ740MzIrnr8LXp7++WtLYYHhzyuZjWdTs2U8y1P2RBepvqaqOIPdabwPzO4P wt8f2hd7h/8YDBHdyQX18sqQBQ/WonHurEpHIg0VRf398AxTdXyqGF+ODR9J/pZXof +S5VtPJfHQ6M3a/z9xz7BgxOUTW0Qjvx16IGmY9VhmQKIlZqfw+lJb6rstj8xabh6g ZY6+95RF9odU7b0zHxdHnKehgNI3ELohBz8k8nrXkqSel2fyTDEytfmAr2yGXdB/bI l2Rb79Kcjvv2dsZZNw/3TB/zORM+jtV3VTRQ8ffxhTqPO55fQFDNu50hic3IMdVPhU mMO2BPcCDqrXw== Original-Received: from pastel (104-195-207-100.cpe.teksavvy.com [104.195.207.100]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2F23E1205EF; Sat, 22 Jun 2019 09:26:39 -0400 (EDT) In-Reply-To: <20190622083525.F1CA5209DE@vcs0.savannah.gnu.org> (Eli Zaretskii's message of "Sat, 22 Jun 2019 04:35:25 -0400 (EDT)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238036 Archived-At: > + (or (null (multibyte-string-p str)) > + (setq str (encode-coding-string 'raw-text-unix str)))) Isn't this the same as (setq str (string-to-unibyte str))? Stefan