* Re: [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals [not found] ` <20190723171715.8F064210EC@vcs0.savannah.gnu.org> @ 2019-07-23 19:57 ` Stefan Monnier 2019-07-24 12:41 ` Lars Ingebrigtsen 0 siblings, 1 reply; 4+ messages in thread From: Stefan Monnier @ 2019-07-23 19:57 UTC (permalink / raw) To: emacs-devel; +Cc: Lars Ingebrigtsen > The usual purpose of the terminal-specific library is to map the > escape sequences used by the terminal's function keys onto more > meaningful names, using @code{input-decode-map} (or > -@code{function-key-map} before it). See the file > +@code{local-function-key-map} before it). Actually, they should mostly use `input-decode-map` instead nowadays (the difference is that `input-decode-map`'s remapping is applied unconditionally, where `(local-)function-key-map`'s remapping is only applied when there's no normal keybinding). > @smallexample > ;; @r{Make the @key{ENTER} key from the numeric keypad act as @kbd{C-j}.} > -(define-key function-key-map [kp-enter] [?\C-j]) > +(define-key local-function-key-map [kp-enter] [?\C-j]) This remapping should probably be applied to any terminal that has a kp-enter key, so I think the change is for the worse. > @@ -190,7 +190,7 @@ key sequence, providing the @acronym{ASCII} key sequence prefix is > already known by Emacs to be a prefix. As a result of providing this > support, some terminal/keyboard/window system configurations, which > don't have a complete set of sensible function key bindings built into > -Emacs in @code{function-key-map}, can still be configured for use with > +Emacs in @code{local-function-key-map}, can still be configured for use with This one should also refer to `input-decode-map`. > -(define-key function-key-map [M-@key{TAB}] [?\M-\t]) > +(define-key local-function-key-map [M-@key{TAB}] [?\M-\t]) [...] > -(define-key function-key-map [f11] [?\e]) > +(define-key local-function-key-map [f11] [?\e]) As above, I think these changes are for the worse. Stefan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals 2019-07-23 19:57 ` [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals Stefan Monnier @ 2019-07-24 12:41 ` Lars Ingebrigtsen 2019-07-24 13:52 ` Stefan Monnier 0 siblings, 1 reply; 4+ messages in thread From: Lars Ingebrigtsen @ 2019-07-24 12:41 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel Stefan Monnier <monnier@iro.umontreal.ca> writes: > Actually, they should mostly use `input-decode-map` instead nowadays (the > difference is that `input-decode-map`'s remapping is applied > unconditionally, where `(local-)function-key-map`'s remapping is only > applied when there's no normal keybinding). I've now changed the two instances to refer to input-decode-map (only). >> @smallexample >> ;; @r{Make the @key{ENTER} key from the numeric keypad act as @kbd{C-j}.} >> -(define-key function-key-map [kp-enter] [?\C-j]) >> +(define-key local-function-key-map [kp-enter] [?\C-j]) > > This remapping should probably be applied to any terminal that has > a kp-enter key, so I think the change is for the worse. Makes sense... but should we then change the bit in the manual that says: @code{local-function-key-map} inherits from @code{function-key-map}, but the latter should not be used directly. Perhaps we should change that to something that says more explicitly what the effect of using function-key-map is? Something like "which should only be used if you want the changes in all terminals"? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals 2019-07-24 12:41 ` Lars Ingebrigtsen @ 2019-07-24 13:52 ` Stefan Monnier 2019-07-25 9:53 ` Lars Ingebrigtsen 0 siblings, 1 reply; 4+ messages in thread From: Stefan Monnier @ 2019-07-24 13:52 UTC (permalink / raw) To: Lars Ingebrigtsen; +Cc: emacs-devel > Perhaps we should change that to something that says more explicitly > what the effect of using function-key-map is? Something like "which > should only be used if you want the changes in all terminals"? Sounds right, yes, Stefan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals 2019-07-24 13:52 ` Stefan Monnier @ 2019-07-25 9:53 ` Lars Ingebrigtsen 0 siblings, 0 replies; 4+ messages in thread From: Lars Ingebrigtsen @ 2019-07-25 9:53 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel Stefan Monnier <monnier@iro.umontreal.ca> writes: >> Perhaps we should change that to something that says more explicitly >> what the effect of using function-key-map is? Something like "which >> should only be used if you want the changes in all terminals"? > > Sounds right, yes, I've now done this. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-25 9:53 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <20190723171714.15080.69466@vcs0.savannah.gnu.org> [not found] ` <20190723171715.8F064210EC@vcs0.savannah.gnu.org> 2019-07-23 19:57 ` [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals Stefan Monnier 2019-07-24 12:41 ` Lars Ingebrigtsen 2019-07-24 13:52 ` Stefan Monnier 2019-07-25 9:53 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.