From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master e21a1da: Allow completion styles to adjust completion metadata Date: Sat, 26 Oct 2019 22:04:29 -0400 Message-ID: References: <20191026132223.21074.15227@vcs0.savannah.gnu.org> <20191026132224.B05E120664@vcs0.savannah.gnu.org> <87imobxiyu.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="195745"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: =?windows-1252?B?Sm/jbyBU4XZvcmE=?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 27 03:05:39 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iOXw3-000opJ-9j for ged-emacs-devel@m.gmane.org; Sun, 27 Oct 2019 03:05:39 +0100 Original-Received: from localhost ([::1]:43784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOXw2-00070T-3t for ged-emacs-devel@m.gmane.org; Sat, 26 Oct 2019 22:05:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49427) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOXv1-00033P-W1 for emacs-devel@gnu.org; Sat, 26 Oct 2019 22:04:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOXv0-0001D3-Tz for emacs-devel@gnu.org; Sat, 26 Oct 2019 22:04:35 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46679) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iOXv0-0001Bt-Q7 for emacs-devel@gnu.org; Sat, 26 Oct 2019 22:04:34 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2872081183; Sat, 26 Oct 2019 22:04:34 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AA22180AC6; Sat, 26 Oct 2019 22:04:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1572141872; bh=XSfj4bjPAx+gU0epv+aY1r5TGaHwn9f9rM0aCVFBMWQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CUJKWtstNvEf+7uwrXlWdwKbkkjtc7lRDuEPAbIqf0W5K2hbrLyj8c2TzGeUiHDbK 9T1ZuosmUM2AxIgjstnxd1RDK54px0y2uey247HSn0bvtdT4KUx3ztfa/z6TOdo5Ku dmydsPfCqo2MyBvFnnCFGXQn8lOig6b/poyerwCD+ku8RoNoQxm1LbAjNktDOvMwQk 2qzdG2SqhApS7eplPiFzndniJYg3GMi0/XpbXL9XVDKKRWDMFn/vpp75Ci3Zaf29oz G+YVf7nENSXJsDajy5/iYto0B1qvaO8Q+WvB/HDgxwrN3yElwcAojDGIId7mMBHgCi +Qy8qxUJEJQhg== Original-Received: from pastel (unknown [216.154.37.243]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5441B12039E; Sat, 26 Oct 2019 22:04:31 -0400 (EDT) In-Reply-To: <87imobxiyu.fsf@gmail.com> (=?windows-1252?Q?=22Jo=E3o_T=E1vo?= =?windows-1252?Q?ra=22's?= message of "Sat, 26 Oct 2019 23:03:37 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241495 Archived-At: > I assumed it is. Do you know that it isn't? nil? I think it can be nil, yes. > BTW I hate this metadata object, I with there were proper > writers/constructors that didn't assume anything about its > cons-implementation. Perhaps I missed something. No, you didn't miss anything. >> BTW, I just changed the bootstrap so that cl-defgeneric should now be >> usable in minibuffer.el. > > Out of energy right now. Be my guest, the switch to cl-generic is > trivally outlined in the now-revert commit. I was about to do that when I saw the issue with `metadata` being potentially nil. Stefan