From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#39190: 28.0.50; two buffers with same buffer-file-name (diff-syntax-fontify-props) Date: Tue, 28 Jan 2020 15:12:03 -0500 Message-ID: References: <875zh73dg8.fsf@betli.tmit.bme.hu> <8736c921s6.fsf@mail.linkov.net> <875zh13e5d.fsf@mail.linkov.net> <87imkwfnyv.fsf@mail.linkov.net> <83blqontlu.fsf@gnu.org> <837e1bo499.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="60235"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39190@debbugs.gnu.org, felician.nemeth@gmail.com, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 28 21:30:51 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iwXVb-000FJl-Mr for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Jan 2020 21:30:51 +0100 Original-Received: from localhost ([::1]:37154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwXEW-0001jB-RQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Jan 2020 15:13:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36101) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iwXEO-0001fI-8c for bug-gnu-emacs@gnu.org; Tue, 28 Jan 2020 15:13:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iwXEN-00087x-8z for bug-gnu-emacs@gnu.org; Tue, 28 Jan 2020 15:13:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55189) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iwXEN-00087C-5V for bug-gnu-emacs@gnu.org; Tue, 28 Jan 2020 15:13:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iwXEN-0005Vy-0d for bug-gnu-emacs@gnu.org; Tue, 28 Jan 2020 15:13:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Jan 2020 20:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39190 X-GNU-PR-Package: emacs Original-Received: via spool by 39190-submit@debbugs.gnu.org id=B39190.158024233721128 (code B ref 39190); Tue, 28 Jan 2020 20:13:02 +0000 Original-Received: (at 39190) by debbugs.gnu.org; 28 Jan 2020 20:12:17 +0000 Original-Received: from localhost ([127.0.0.1]:32928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwXDc-0005Ui-PZ for submit@debbugs.gnu.org; Tue, 28 Jan 2020 15:12:17 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:34567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iwXDa-0005UJ-P8 for 39190@debbugs.gnu.org; Tue, 28 Jan 2020 15:12:15 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3AE8F101359; Tue, 28 Jan 2020 15:12:09 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 3097F1012B8; Tue, 28 Jan 2020 15:12:07 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1580242327; bh=o64WLv61uHWOrczCh2e1gGil3riLI/xkAxchYUlHnV0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=T46R9WjlvkgRmwmQ9Vy30h/dW5yRXakXPwewgxzLMTcpHfs0HSVubnKVRSrlDVoTF gUAV6oSoGmRhNeXDVDpPXBWDDBZahJI67DMMYkUgNtfrRQykMobf9cfRm8dNH10NSe jw30zTsLaS7dtKqKx01/8dPkUG1Ch/KSnr1kDERh18QMgSVPlVjrDU1U+KtlTLk4bu hiSJey9b42lsezHchBd6PXoMUc4kBllSw0mMYBwvKS3yqx3NgIsb2i02KbG08it/1/ tJRGqAxKb1ttUjMp7A+8rZirLm7EpfuLwr1Ske0vxP3zZKj/zqE1UVTjgY46+VgdlU QnpVHOhclQaJQ== Original-Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id C3CA7120287; Tue, 28 Jan 2020 15:12:06 -0500 (EST) In-Reply-To: <837e1bo499.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 28 Jan 2020 19:54:58 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175368 Archived-At: > So this is because those modes They're not "modes", really, they're features that create a temp buffer related to file FOO and need to set this buffer to the same mode as file FOO (e.g. this happens in vc-revision-other-window, or also in diff-mode where we grab a hunk's text and want to put it in its corresponding major mode to give it mode-specific highlighting). > set buffer-file-name instead of activating the major mode directly? Right: they don't know which major mode should be used, so they set buffer-file-name and then call set-auto-mode (which looks up auto-mode-alist and directory local vars appropriately). > And by setting buffer-file-name they by side effect tell unrelated > features that this buffer is associated with a file? Indeed. > If so, then I'm not sure I understand the solution. The offending > modes will have to be modified to use this new variable instead of > buffer-file-name, no? That's what the patch does, yes (modulo the fact that they're not really "modes"). > And if we have to modify them, then why not do TRT while at that, > i.e. call the major mode directly instead of setting some variable? We set the variable in order to find out what mode to use. Stefan