From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 40149b8: * lisp/emacs-lisp/eieio.el (oset, oset-default): Mark as obsolete Date: Mon, 04 May 2020 22:43:30 -0400 Message-ID: References: <20200503220546.4505.39814@vcs0.savannah.gnu.org> <20200503220548.6C53420B5B@vcs0.savannah.gnu.org> <87tv0vdxf6.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="105424"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 05 04:45:03 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVnZt-000RGs-Td for ged-emacs-devel@m.gmane-mx.org; Tue, 05 May 2020 04:45:01 +0200 Original-Received: from localhost ([::1]:36176 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVnZs-0004Ob-RC for ged-emacs-devel@m.gmane-mx.org; Mon, 04 May 2020 22:45:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVnYk-0003wZ-98 for emacs-devel@gnu.org; Mon, 04 May 2020 22:43:50 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:15249) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVnYf-0007RF-Ls for emacs-devel@gnu.org; Mon, 04 May 2020 22:43:49 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 86D34450925; Mon, 4 May 2020 22:43:33 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 64572450914; Mon, 4 May 2020 22:43:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1588646612; bh=49DqIdKIBkxDTpHJ5+c6zI1VRwls75RmNJdWA2oXnjs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=d4QQkY5pTT5vedZrzuMPKSmm7543HL9Vgcftq+L8w8ccmXIUPLBdHxs+5hu7CSptF xPXB1qr8xgey/rTlGiMjb8siF2UuqpNvzQ2YH8nJELFby+56qJO2zjpNWndtf0eLUc xcv+srwVSXqCJcAEHZlWsW4FRLDjnXvyI/YlZRw8jLoo+GeLCPshEjOzbmfmdIng1l ZYQY9hCCCu8pByk+Bmh454XwRBFqCGGI4O4UyZ9Zkfodvvifcg7OQFnE1Ni6eRBosc DAc4YsyuCceYAjrEudq4UaDlsN61VdmgMiQPeepI3WuLlWXTblS/HvGqs5k0As1xk3 qTAMbs+EQRkDw== Original-Received: from alfajor (unknown [216.154.3.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2CC93120555; Mon, 4 May 2020 22:43:32 -0400 (EDT) In-Reply-To: <87tv0vdxf6.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 05 May 2020 01:42:53 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/04 22:43:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248926 Archived-At: > Subject: [PATCH] Fix obsolete EIEIO uses Looks good, thank you. > +** The EIEIO macros 'oset' and 'oset-default' are declared obsolete. > +Their 'setf'-able counterparts 'oref' and 'oref-default' can be used > +instead. We could also mention the properly namespaced `eieio-oset` as an alternative if a function setter is needed. Stefan