From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: project.el: git submodules? Date: Wed, 13 May 2020 22:55:30 -0400 Message-ID: References: <875zd1ni5i.fsf@md5i.com> <55769244-c84c-dff0-4427-9ff688f81af5@yandex.ru> <87v9l0nar5.fsf@md5i.com> <95a8c285-125f-afda-b1bc-d1c0452e5c31@yandex.ru> <1bc2052e-b26b-1f3d-f78c-a22112861f27@yandex.ru> <7b247aac-28bd-94c1-2546-524edde9b781@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="45206"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Michael Welsh Duggan , Gary Oberbrunner , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 14 04:56:18 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jZ42h-000BdM-Rj for ged-emacs-devel@m.gmane-mx.org; Thu, 14 May 2020 04:56:15 +0200 Original-Received: from localhost ([::1]:38736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZ42g-000549-TH for ged-emacs-devel@m.gmane-mx.org; Wed, 13 May 2020 22:56:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZ42C-0004Sz-0m for emacs-devel@gnu.org; Wed, 13 May 2020 22:55:44 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41162) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZ42A-0003k0-Lf for emacs-devel@gnu.org; Wed, 13 May 2020 22:55:43 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id B2BDE450C88; Wed, 13 May 2020 22:55:40 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 3660C450C85; Wed, 13 May 2020 22:55:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1589424932; bh=4QEaySP07rYF7Vc6SG/ETCLQ1RQ9wEK7YnLbAqP40RQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Wl3kd1sD2/tEAt8yGZAp/DdpzyCE7yYOde+8B1qvF65zYWC/d9vkbDk/bnL98YU6l YY1fM58pDC3UPHz/lORWmO4xN8fsAVBd4QhWRcctLrdDATLm0OvsHAATj6afmxFuRD glE3asdndV7A03nqo5SjUiAkLWWr/FW4q+YLMRT3uYU6eXgscmGYMSMWS0B1M0Fc99 Gndp/BqzpbYN2KduDkXV62FKPle6RLAtpEqwonwEyaS5HKig6jlruILHIXoU3MCnz0 PtPmUMtnhPSnlpTq6D+H2wMe2CavVP/ykppGyJxNo7knrpstUo8GnJoBpZ+tZxhCII VOV0l20m3uavg== Original-Received: from alfajor (unknown [216.154.3.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A516612060B; Wed, 13 May 2020 22:55:31 -0400 (EDT) In-Reply-To: <7b247aac-28bd-94c1-2546-524edde9b781@yandex.ru> (Dmitry Gutov's message of "Thu, 14 May 2020 03:32:55 +0300") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/13 22:55:41 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250182 Archived-At: > I even have a patch, but here's another thought: wouldn't this mistakenly > punish people who keep their $HOME as a Git repository to sync > between machines? Depends if the Git worktrees within their $HOME use the same repository as the one used for $HOME. But yes, if they do, then by all accounts, they would qualify as "submodules" in my book (and the only way to tell if they should be treated as such or not would be by asking the user). But we could try and be more strict in our definition of what is a "submodule" for the purpose of finding the project root. And it's likely that in the end we should let the user control what happens, because depending on the specific use of submodules, I can imagine cases where the user would want to consider the project's root to be that of the submodule rather than that of the containing Git tree. Stefan