From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#42147: 28.0.50; pure vs side-effect-free, missing optimizations? Date: Wed, 29 Jul 2020 16:39:52 -0400 Message-ID: References: <3A9CC2A3-8307-47B2-8D80-795C0AF020E1@acm.org> <0433A879-C98D-4B1A-B85C-A15DA9289099@acm.org> <1621669100.2102667.1593639091621@mail.yahoo.com> <33C2E2C8-16A6-47A9-B3A4-8A5F43648E04@acm.org> <51FE77F3-CA05-459A-9601-9E1EEBC1E2FE@acm.org> <1213DD41-01F9-4605-8D32-D750B6CE2B35@acm.org> <81F989D1-3CC4-450B-89D6-E9C16F766277@acm.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5847"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Philipp Stephani , Paul Eggert , Andrea Corallo , 42147@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 29 22:41:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0ssz-0001Qd-RC for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Jul 2020 22:41:14 +0200 Original-Received: from localhost ([::1]:39534 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0ssy-0003ot-TW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Jul 2020 16:41:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0sso-0003oV-PZ for bug-gnu-emacs@gnu.org; Wed, 29 Jul 2020 16:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50506) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k0sso-0005Ex-9y for bug-gnu-emacs@gnu.org; Wed, 29 Jul 2020 16:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k0sso-0007BR-3S for bug-gnu-emacs@gnu.org; Wed, 29 Jul 2020 16:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Jul 2020 20:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42147 X-GNU-PR-Package: emacs Original-Received: via spool by 42147-submit@debbugs.gnu.org id=B42147.159605520527528 (code B ref 42147); Wed, 29 Jul 2020 20:41:02 +0000 Original-Received: (at 42147) by debbugs.gnu.org; 29 Jul 2020 20:40:05 +0000 Original-Received: from localhost ([127.0.0.1]:33818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0srt-00079w-1I for submit@debbugs.gnu.org; Wed, 29 Jul 2020 16:40:05 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k0sro-00079J-A7 for 42147@debbugs.gnu.org; Wed, 29 Jul 2020 16:40:03 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 8423180F4E; Wed, 29 Jul 2020 16:39:54 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 13CCF808C6; Wed, 29 Jul 2020 16:39:53 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1596055193; bh=He5M9aRvL9yQ77hIe38n57jfgh0VCd3rtablE04f+Uw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CcFB98/qw5jDRTUu/M3hFhP8j+nEE4Tydn3wJzNU4lwKCGAkB8wX1i/wUJkWZuMjf Bq5kQJlurT4KB5FA7J56JqMIYYmDRj2U4sHeeYYDLEHh1YdkppOohbE4OLz/YnEM5v 9m6z+SGdDksKPWx6eDzgB4XKMHx7r+60wkXjK7zuZkbsVQ5MA7FvXvmYd0X2j0EPkH kxBV+A+XFJstY4Wi9Vu0TCDSZz0azCpEI/rfY583ZrXsIxYFv9zDQVRLEyN3o5aIT+ 5Ow52sqedN6QO1J+Rcj8ZYRhkkrmb8OgOC+K64s2Eau25lWFQdFtLD5XwxgSvWM76O bseN5ZehrrarQ== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E6FD41204BD; Wed, 29 Jul 2020 16:39:52 -0400 (EDT) In-Reply-To: ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Wed, 29 Jul 2020 18:03:27 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183680 Archived-At: > Regarding package-get-version: perhaps we should drop the 'pure' property > and just let callers wrap it in eval-when-compile? I'd rather not: the benefit is too subtle, I'd expect most users won't know/bother to use `eval-when-compile` around it even though I'd expect a vast majority of the uses can benefit from compile-time evaluation. In contrast the cases where the impurity will get in the way should be rare. Feel free to add a `save-match-data` if you think it's worth the trouble (but please include a comment explaining it's only there in order to satisfy the `pure` annotation). Stefan