From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#43329: 28.0.50; Incorrect indentation for variables starting with `def' in let form Date: Sun, 13 Sep 2020 11:24:43 -0400 Message-ID: References: <87y2lg1uek.fsf@gnus.org> <85o8mcl199.fsf@gmail.com> <87h7s32ooe.fsf@gnus.org> <87a6xtzw02.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27761"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Philipp Stephani , Noam Postavsky , 43329@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 13 17:25:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHTsO-000771-19 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Sep 2020 17:25:12 +0200 Original-Received: from localhost ([::1]:45884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHTsM-0005PE-Qp for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Sep 2020 11:25:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHTsE-0005P4-6H for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 11:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39827) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHTsD-0004nx-T2 for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 11:25:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHTsD-0001KD-Os for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2020 11:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Sep 2020 15:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43329 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 43329-submit@debbugs.gnu.org id=B43329.16000106965075 (code B ref 43329); Sun, 13 Sep 2020 15:25:01 +0000 Original-Received: (at 43329) by debbugs.gnu.org; 13 Sep 2020 15:24:56 +0000 Original-Received: from localhost ([127.0.0.1]:51373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHTs7-0001Jn-Jh for submit@debbugs.gnu.org; Sun, 13 Sep 2020 11:24:55 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHTs3-0001JY-CC for 43329@debbugs.gnu.org; Sun, 13 Sep 2020 11:24:54 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F153E80DC9; Sun, 13 Sep 2020 11:24:45 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 80EDF80BCE; Sun, 13 Sep 2020 11:24:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1600010684; bh=PT3DfKcI9I8R0QwVdGwemN5e+Betgjerjz9mexGHGUE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=gDvua7tJvWoyRIScEby2U/XLJm7dVNnOJDhFc3GSBUai3U9fvtqKGq50pwk3uFice pxr+dUPSN+Bo6cspQEl0hiD6ERPI2XndykIyETmrGqlWdVhAz3aEzgOMXBWZK0oump 38z+pcoVOtqGg6jfqn93CYOHesqsL0ai5FkWhmKJaguuq3naXyJZRBD5hEi7gowzN4 bUAJ56AMfs+CRanQpLbUpXLB9+nu7d5EySGI0EhMZHS2q+63/vp1FTWEL3WB4cBmvA ZgaOpSX++FXI+YRW2+mZRoDKAomE9W5PHZcLhgrcALW4tHOPpHLq4iZ9SxwSsJz6Ux Nv1mRb0bzQQuw== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EBCB012076C; Sun, 13 Sep 2020 11:24:43 -0400 (EDT) In-Reply-To: <87a6xtzw02.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 13 Sep 2020 14:44:45 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187968 Archived-At: > But the (def* thing is a heuristic, and we could say that we only use > that heuristic at the top level? We can replace one heuristic with another, yes. That exchanges misindentationss for other misindentations. > We should then mark all the (def* things we have in-tree with explicit > indentation marking (which I think we should do anyway, really). Indeed (and I think we've been getting there bit by bit. Not sure how far we stand from that nowadays). Of course, that won't help with (let ((defvar 3)) (+ defvar 5)) and other oddball cases ;-) Stefan