all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: help-gnu-emacs@gnu.org
Subject: Re: Adding String to Beginning of Lines
Date: Tue, 10 Nov 2020 17:31:02 -0500	[thread overview]
Message-ID: <jwvr1p0voe3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: 87y2j9f186.fsf@web.de

> If you look at the definition:
>
> (defsubst string-empty-p (string)
>   "Check whether STRING is empty."
>   (string= string ""))

FWIW, I agree with Louis on this one: (equal string "") is shorter and
just as clear as (or even more clear than) `(string-empty-p string)`,
so I'm no fan of such a definition.

> | (defun rcd-string-empty-p (s)
> |   "Returns T if string is empty or NIL"
> |   (let ((s (if (null s) "" s)))
> |     (if (stringp s)
> | 	(if (zerop (length s)) t nil))))
>
> That's more or less the same as
>
> (defun rcd-string-empty-p (s)
>   (or (null s) (and (stringp s) (zerop (length s)))))

BTW since (length nil) is zero, this can be reduced in most cases to
(zerop (length s)), the main difference being that the shorter
definition signals an error if passed an object that's neither an array
nor a proper list.

> But why handling an empty list specially, and not other empty sequences,
> like the empty vector?  That's what `seq-empty-p' in seq.el does, btw.

Indeed,


        Stefan




  parent reply	other threads:[~2020-11-10 22:31 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 10:43 Adding String to Beginning of Lines Christopher Dimech
2020-11-10 11:10 ` tomas
2020-11-10 11:19   ` Christopher Dimech
2020-11-10 11:29   ` Christopher Dimech
2020-11-10 11:54     ` Michael Heerdegen
2020-11-10 11:58       ` Christopher Dimech
2020-11-10 12:07         ` Michael Heerdegen
2020-11-10 12:03       ` Christopher Dimech
2020-11-10 12:16         ` Michael Heerdegen
2020-11-10 13:40           ` Christopher Dimech
2020-11-10 14:06             ` Jean Louis
2020-11-10 14:29               ` Michael Heerdegen
2020-11-10 19:12                 ` Jean Louis
2020-11-10 19:42                   ` Michael Heerdegen
2020-11-10 21:22                     ` Jean Louis
2020-11-11 10:59                       ` Michael Heerdegen
2020-11-17 16:06                         ` Jean Louis
2020-11-17 16:28                           ` Michael Heerdegen
2020-11-10 22:31                     ` Stefan Monnier [this message]
2020-11-10 23:00                       ` Drew Adams
2020-11-11 21:37                         ` Michael Heerdegen
2020-11-10 14:16             ` Michael Heerdegen
2020-11-10 14:38               ` Christopher Dimech
2020-11-10 14:49                 ` Michael Heerdegen
2020-11-10 17:52                   ` Christopher Dimech
2020-11-10 18:03                     ` Michael Heerdegen
2020-11-10 18:25                       ` Christopher Dimech
2020-11-10 18:49                         ` Michael Heerdegen
2020-11-10 18:56                           ` Christopher Dimech
2020-11-10 19:02                             ` Michael Heerdegen
2020-11-10 19:29                               ` Christopher Dimech
2020-11-10 20:07                                 ` Michael Heerdegen
2020-11-10 22:45             ` tomas
2020-11-11 11:16               ` Michael Heerdegen
2020-11-11 13:22                 ` Christopher Dimech
2020-11-11 13:56                   ` Michael Heerdegen
2020-11-11 14:07                   ` tomas
2020-11-11 14:49                     ` Christopher Dimech
2020-11-11 17:20                 ` Christopher Dimech
2020-11-11 18:12                   ` Michael Heerdegen
2020-11-11 18:25                     ` Stefan Monnier
2020-11-11 18:35                     ` Christopher Dimech
2020-11-10 14:03         ` Jean Louis
2020-11-10 11:42 ` Michael Heerdegen
2020-11-10 18:47   ` H. Dieter Wilhelm
2020-11-12 19:01 ` Dante Catalfamo
2020-11-14 22:09   ` Jamie Beardslee
2020-11-14 23:17     ` Stefan Monnier
2020-11-14 23:39       ` Jamie Beardslee
2020-11-15  9:12       ` tomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvr1p0voe3.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.