From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#41412: 27.0.90; Value of default directory in completions buffer Date: Fri, 22 Jan 2021 17:50:18 -0500 Message-ID: References: <87pnay7azg.fsf@penguin> <87k0s4wwbl.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33438"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Omar =?UTF-8?Q?Antol=C3=ADn?= Camarena , 41424@debbugs.gnu.org, 41412@debbugs.gnu.org, Stefan Kangas To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 22 23:51:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l35Gp-0008YX-EE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Jan 2021 23:51:11 +0100 Original-Received: from localhost ([::1]:57092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l35Go-0005gO-Fo for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Jan 2021 17:51:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l35Gg-0005dI-3K for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2021 17:51:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50088) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l35Gf-0001ti-Rm for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2021 17:51:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l35Gf-0003qp-Oq for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2021 17:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Jan 2021 22:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41412 X-GNU-PR-Package: emacs Original-Received: via spool by 41412-submit@debbugs.gnu.org id=B41412.161135583614733 (code B ref 41412); Fri, 22 Jan 2021 22:51:01 +0000 Original-Received: (at 41412) by debbugs.gnu.org; 22 Jan 2021 22:50:36 +0000 Original-Received: from localhost ([127.0.0.1]:33392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l35GG-0003pY-85 for submit@debbugs.gnu.org; Fri, 22 Jan 2021 17:50:36 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l35GE-0003pI-69; Fri, 22 Jan 2021 17:50:35 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9449A440F18; Fri, 22 Jan 2021 17:50:28 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id AE582440872; Fri, 22 Jan 2021 17:50:19 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1611355819; bh=bJaW5iCmcCY/Mh2XTWTuyaYTrOxd/vAkbsOuJl9CMOI=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=G5uzcsOJEfGjHgzD2jM9yl0tnzsLa1m6OT5xcLeZFEHY1VHbRS8Sfe6f4VJpqVbpz 4CYYD0HCtM36b7566qiDxTVcg3S1bIvts1O37sbYighEFDdxye53pKdsV/ZPUjurDz hlYbgl5Ix8AODVkydEGVEUdiou9fB5ZQ2Blv7FCleRb0Do0vLJpEzJ1vafIqLServF 70fNYfiAitATlUrwYwvu4Ms9JpY3cKPh+21PDH9LScIboJkiHrxIFRFv6xM4M4fAUH my6Uw87+qVHFD5AgOUsDLJGrCbCjNwOKgII5BP0opOoXBewbahGrnUwNgZWsOuLIAW 84d8REpCfrqIw== Original-Received: from alfajor (65-110-220-188.cpe.pppoe.ca [65.110.220.188]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 4440112032C; Fri, 22 Jan 2021 17:50:19 -0500 (EST) In-Reply-To: <87k0s4wwbl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 22 Jan 2021 21:28:14 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198415 Archived-At: > I think that sounds likely. The patch that introduced this code is > below, and it indeed changes the `file-name-directory' to > `file-name-as-directory' (among other things). But it also changed a fair bit around it. And the `substring` is quite different. When I look at the history of this code, 30c7e54299fc81cd3122a17ef130ab69e9855f99 looks wrong. In order not to change the behavior, I suspect it should have been: (buffer-substring (minibuffer-prompt-end) (+ (minibuffer-prompt-end) (or completion-base-size 0)))))))) and then 326fdb9ec05ab5e4aec0c7064272bb3d223e9875 looks wrong again since it presumes that `completion-base-size` is nil whereas it usually isn't/wasn't when completing files. Stefan