From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Caching where-is-internal (was: (icomplete-vertical-mode): Add support for affixations and, annotations) Date: Mon, 24 May 2021 12:22:51 -0400 Message-ID: References: <87zgwlb4xc.fsf@gmail.com> <87eedxrqz4.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36787"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Juri Linkov , =?windows-1252?B?Sm/jbyBU4XZvcmE=?= , emacs-devel@gnu.org To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 24 18:24:15 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llDNF-0009JJ-Ow for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 18:24:13 +0200 Original-Received: from localhost ([::1]:58224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llDNE-0002Pv-SR for ged-emacs-devel@m.gmane-mx.org; Mon, 24 May 2021 12:24:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llDM6-000106-OP for emacs-devel@gnu.org; Mon, 24 May 2021 12:23:02 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:45133) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llDM4-0006Zp-L5 for emacs-devel@gnu.org; Mon, 24 May 2021 12:23:02 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id A4CB3440A6D; Mon, 24 May 2021 12:22:58 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 7C5A7440A53; Mon, 24 May 2021 12:22:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1621873377; bh=mhgxuNT3GiG0t52tWLON390S0K+oc82k9jJlPcUICOg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HD0OdfIlQmdFfJu9iDTKxCru9ggx5I49JPfcTA2f3sVTRQXJpweZ9agJ4PMKlxKIa O8ril3hxh33OdmFWQ2YeowuB+luYbXtbcY55eh4peVqS/sikpL244Cm+ET8Wp4hHCo a6z/tfQl0S4eGEJAK3XCpmTc2YhYN8/MyWKf921VK9W6QWmFhvEcFLAhIohjV7xK7X b10UryBfLHSgbVt5ZhzxZqG2b3p6P1lH5Okpok79LLGQdfWQUNx9hMbV4PG7xaUBTj XpWaYWeNj9tCDdiAF5q5w8kqoW9f/V7CqBPBA3n8CPZgYA+g6mmi5qJKS3ajEVDL29 AeCmsQhAfLmkg== Original-Received: from alfajor (69-196-163-239.dsl.teksavvy.com [69.196.163.239]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 37FB9120225; Mon, 24 May 2021 12:22:57 -0400 (EDT) In-Reply-To: (Daniel Mendler's message of "Mon, 24 May 2021 12:34:36 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269770 Archived-At: > That is of course correct that it is better to add some internal > pre-computation. In the case of Marginalia we also have an extra caching > for the keybindings, since the `where-is-internal` function is > relatively slow. This matters when computing the keybinding annotations > on many candidates. `where-is-internal` is supposed to do its own caching already (I added that around the time of Emacs-21 because it was making construction of the menubar too slow). So if you see problems on that side, please report them. Stefan