From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 49953@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>,
juri@linkov.net
Subject: bug#49953: 28.0.50; tmm is broken on compiled menus
Date: Mon, 09 Aug 2021 14:23:09 -0400 [thread overview]
Message-ID: <jwvr1f2a3du.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <83czqmh7dr.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 09 Aug 2021 20:09:52 +0300")
>> > This regression began to occur after merging native-compilation.
>> > It seems the problem is that tmm-get-keymap does very strange things:
>> >
>> > (cond ((if (listp elt)
>> > (or (keymapp elt) (eq (car elt) 'lambda))
>> > (and (symbolp elt) (fboundp elt)))
>> >
>> > I don't know why it checks for 'lambda' and 'symbolp',
>> > but such checks fail on a compiled function.
>>
>> Yeah, or why the listp at all... I think the correct test in all these
>> cases are (or (keymapp elt) (functionp elt))? So I've now done that on
>> the trunk, and that seems to make things work. But there may be
>> something subtle here, so I guess we'll see...
>
> I have a vague recollection that at least some of those are used, so I
> brought Stefan on-board this discussion, in the hope that he could
> show us the light.
Sorry, my lightbulb is currently out, but I agree that the above test
seems to want to do (or (keymapp elt) (functionp elt)) just in
a clumsy way.
Stefan
prev parent reply other threads:[~2021-08-09 18:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 7:12 bug#49953: 28.0.50; tmm is broken on compiled menus Juri Linkov
2021-08-09 13:20 ` Lars Ingebrigtsen
2021-08-09 17:09 ` Eli Zaretskii
2021-08-09 18:23 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr1f2a3du.fsf-monnier+emacs@gnu.org \
--to=bug-gnu-emacs@gnu.org \
--cc=49953@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.