From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Moving kbd to subr.el Date: Fri, 15 Oct 2021 12:05:52 -0400 Message-ID: References: <20211004081724.6281.11798@vcs0.savannah.gnu.org> <878ryxakv9.fsf@gnus.org> <834k9km5no.fsf@gnu.org> <83k0iflsze.fsf@gnu.org> <874k9jzu7a.fsf@gnus.org> <874k9juy0r.fsf@gnus.org> <87mtnbtimj.fsf@gnus.org> <87wnme4m6f.fsf@gnus.org> <83zgraim4f.fsf@gnu.org> <83y26uilww.fsf@gnu.org> <87pms6wmh5.fsf@igel.home> <874k9i4ghl.fsf@gnus.org> <87ee8m2xl9.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38187"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Eli Zaretskii , Andreas Schwab , Emacs developers To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 15 18:12:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mbPoN-0009g6-Gp for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Oct 2021 18:11:59 +0200 Original-Received: from localhost ([::1]:36382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbPoM-0005Ku-3S for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Oct 2021 12:11:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbPil-00073F-5s for emacs-devel@gnu.org; Fri, 15 Oct 2021 12:06:13 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:64089) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbPif-0000Da-GV; Fri, 15 Oct 2021 12:06:09 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E67AF440BB1; Fri, 15 Oct 2021 12:06:01 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 75971440B12; Fri, 15 Oct 2021 12:06:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1634313960; bh=mAXczWLhobeTx38yjqqrH79IVgxojbDY9tUHObT0lok=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=o/AE8yhwTj9c95QdO5Hy8HpBHbxWhIfzExakwOvJhn0Qac9tM0HfrUPV5i026mGbf lPGqDaXoEXy9irwIcPedo0CbgK1zOaVBAGnhWQrzWh6Rb15aF/vzb26808SbtVkA+G 91e4WUfPPCEwCAdSvFrMA+P/RVMv4yRqjfZqiKo5ZX0c3yr/ScRrjj3NBlgptHPFRW ti2ZcxT/o22kqle6lZsisoLn1N+3WFDC8VlZDMR53da9D1JsyKM5AkToIEWsUAOmpt RH+l43snjpjGPLTlq17NrNzQ62qOSlKW/nji/PI408jQXDdJk7zPVx8l22dK8qvfu3 RbXt6gfP7I19Q== Original-Received: from ceviche (modemcable004.216-203-24.mc.videotron.ca [24.203.216.4]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EA7B5120323; Fri, 15 Oct 2021 12:05:59 -0400 (EDT) In-Reply-To: (Stefan Kangas's message of "Fri, 15 Oct 2021 16:44:11 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277128 Archived-At: >> because it probably means that we (at some point in the future) can >> drop the string representation altogether (as a return value from >> `kbd'). > Hmm, I'd like to hear what Stefan Monnier has to say about this. FWIW, I removed the `need-vector` arg (and simplified the code accordingly assuming it's always non-nil) and haven't found any problems, so the uses that aren't prepared to handle a string return value seem quite rare (tho Murphy swears they exist). > A good first step should in any case be to say in the 'kbd' docstring > that the string syntax is considered obsolete, and that callers should > prepare to handle a vector return value instead. Perhaps we could > document this already in emacs-28. Fine by me, Stefan