From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: bug#49265: [External] : bug#49265: 28.0.50; repeat mode feature request Date: Mon, 25 Oct 2021 16:57:19 -0400 Message-ID: References: <87czs53aei.fsf.ref@aol.com> <87czs53aei.fsf@aol.com> <87h7hh6o8t.fsf@mail.linkov.net> <87wnqcv25h.fsf@mail.linkov.net> <874kdfekr8.fsf@gmail.com> <87r1gj6say.fsf@mail.linkov.net> <87r1cdz72i.fsf@gmail.com> <875ytn8ufp.fsf@mail.linkov.net> <877de2zeqk.fsf@gmail.com> <87sfwqgrt4.fsf@mail.linkov.net> <87y26ixkb8.fsf@gmail.com> <87tuh5lgc7.fsf@mail.linkov.net> <87bl3dscup.fsf@gmail.com> <87sfwp9zs8.fsf@igel.home> <87sfwpuh1g.fsf@mail.linkov.net> <87tuh4ri45.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3207"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Juri Linkov , Andreas Schwab , Stefan Kangas , Ergus , Drew Adams , emacs-devel To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 25 22:59:45 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mf74L-0000dE-Ox for ged-emacs-devel@m.gmane-mx.org; Mon, 25 Oct 2021 22:59:45 +0200 Original-Received: from localhost ([::1]:40062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mf74K-00088e-0O for ged-emacs-devel@m.gmane-mx.org; Mon, 25 Oct 2021 16:59:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mf73K-0007Qz-66 for emacs-devel@gnu.org; Mon, 25 Oct 2021 16:58:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:5759) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mf73G-00046e-He for emacs-devel@gnu.org; Mon, 25 Oct 2021 16:58:40 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 848601002CE; Mon, 25 Oct 2021 16:58:35 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 0966B100129; Mon, 25 Oct 2021 16:58:34 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1635195514; bh=xNG4pZd4XEaXZOuPr0csjWEXcrW668Nk9RWgbCRohWs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=HyVKOpkRhwMbPxV2tFlhDSHo7EuedylabItlJE8YgLQE27js9blP/a5QDi3ps8aeA JWTnAF5+0Ef3XparKxpQdvjKGONzs1w9maKMyJmkw0ko3fArzDWxULY7pwdPnzKCs8 szBB5GRS0SfVht4+1qsiWroFupLnp3osvKwQUKFOT9CruMBTPHt0+XXJZILVJWMmo1 M8WpQYFyzs6T6BV9GmAVq9sNVUxFhzWAtakXlz1gDAzmwQKinRWmzU98i22kElsvEO HrWs1YZehKPa8UH8t+62ep77HQDylCjAJ0jKq18cPl++VyNptiFQFuY+8xcYCgOA7c uxnZc79Zo1zzQ== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D579E1205E4; Mon, 25 Oct 2021 16:58:33 -0400 (EDT) In-Reply-To: <87tuh4ri45.fsf@gmail.com> (Robert Pluim's message of "Mon, 25 Oct 2021 21:59:06 +0200") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277798 Archived-At: > Stefan> The \\<...> doesn't override all other maps, so the `undo` command is > Stefan> still found to be bound to `C-x u` in the global map. > Right. I think it should look *only* in the specified map, otherwise > what's the point of specifying it? The common case is to specify the keymap that will likely be active when the command is used. Maybe you're right that we shouldn't look elsewhere, but I'd be surprised if there aren't docstrings that rely on the current behavior. > Stefan> But I agree that maybe `where-is-internal` could be told > Stefan> here to give precedence to bindings found in the > Stefan> \\<...> map. > > `where-is-internal' is not the issue. If you pass it (list keymap) it > will look only in 'keymap'. But substitute-command-keys passes it > 'keymap', which allows it to look in the global map as well. > > Perhaps something like this? Sounds about right, tho it disregards other keymaps than `keymap` and `global-map`. Maybe we should do (or (where-is-internal fun (list keymap) t) (where-is-internal fun nil t)) instead to avoid this problem. Stefan