From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master c6dd8dd: * lisp/emacs-lisp/macroexp.el: Improve last change Date: Thu, 02 Dec 2021 14:58:39 -0500 Message-ID: References: <20211202035200.9877.9609@vcs0.savannah.gnu.org> <20211202035202.04FD820ABB@vcs0.savannah.gnu.org> <878rx32nnw.fsf@gnus.org> <87mtlj0zyf.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8868"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Kangas , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 02 20:59:51 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mssFC-00024u-Pp for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Dec 2021 20:59:50 +0100 Original-Received: from localhost ([::1]:38674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mssFB-0000jg-KT for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Dec 2021 14:59:49 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mssED-0008Sd-TX for emacs-devel@gnu.org; Thu, 02 Dec 2021 14:58:50 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22324) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mssEB-0001sx-3Z for emacs-devel@gnu.org; Thu, 02 Dec 2021 14:58:49 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 22E3A800B3; Thu, 2 Dec 2021 14:58:42 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 841048041E; Thu, 2 Dec 2021 14:58:40 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1638475120; bh=XqS/LejkxUP3GLkeexJc24oeavsj1APUk714XVvYvM0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=iaL1CUCkQ8euXuqJvrYtNQHYqwmMrurzEC10hQB4B/4TXXUEpPMFCzP/iBAwQobtq 6cMuxgiG2DGPVaBc2U2rHYHW0utHZ47a0Ool9EWG0llFBYiTzG0mMMEDTfHL5nU20t myf99f/X5XpqaozjhrLa2NMj8y5VSEZGtyKigVINldRFRc1PmRIkTk26gGtWUoJ6ry +XCSn94T7qBPTVH9HeUhiJwevG7MzhIzRDCXMSYoyAJnxAsZScPwVQhMr7LTpGFvPp 0neIbK3cJPEkC/C8MBy7IMVyS+IoNFJF8CZXuAjsGD1asMC2aTYPmu78utZWHmiOia dYGtUjb6WWIRA== Original-Received: from alfajor (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6A81B1201B2; Thu, 2 Dec 2021 14:58:40 -0500 (EST) In-Reply-To: <87mtlj0zyf.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 02 Dec 2021 16:49:12 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280782 Archived-At: > I've now changed it to not bug out, but I haven't looked closely at the > logic You made exactly the same change I was about to commit (down to the change in layout to fix the excessive indentation). > -- why is the `warning' a nil there anyway? It's not the warning but the "category" where nil means it's not in any particular category. Stefan