* Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang [not found] ` <20220102125921.CEC93C0DA1A@vcs2.savannah.gnu.org> @ 2022-01-02 15:11 ` Stefan Kangas 2022-01-02 16:30 ` Mattias Engdegård 0 siblings, 1 reply; 7+ messages in thread From: Stefan Kangas @ 2022-01-02 15:11 UTC (permalink / raw) To: Mattias Engdegård, emacs-devel Mattias Engdegård <mattiase@acm.org> writes: > +(defun flymake-tests--gcc-is-clang () > + "Whether the `gcc' command actually runs the Clang compiler." > + (string-match "[Cc]lang version " > + (shell-command-to-string "gcc --version"))) We have a similar check in test/lisp/cedet/semantic/bovine/gcc.el (let ((semantic-gcc-test-strings (list (semantic-gcc-query "gcc" "-v")))) ;; Some macOS machines run llvm when you type gcc. (!) ;; We can't even check if it's a symlink; it's a binary placed in ;; "/usr/bin/gcc". So check the output and just skip this test if ;; it looks like that's the case. (unless (string-match "Apple \\(LLVM\\|clang\\)\\|Xcode\\.app" (car semantic-gcc-test-strings)) ...)) Should these tests perhaps be consolidated somehow? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang 2022-01-02 15:11 ` master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang Stefan Kangas @ 2022-01-02 16:30 ` Mattias Engdegård 2022-01-02 16:46 ` Stefan Kangas 2022-01-02 18:12 ` Eli Zaretskii 0 siblings, 2 replies; 7+ messages in thread From: Mattias Engdegård @ 2022-01-02 16:30 UTC (permalink / raw) To: Stefan Kangas; +Cc: emacs-devel 2 jan. 2022 kl. 16:11 skrev Stefan Kangas <stefankangas@gmail.com>: > We have a similar check in test/lisp/cedet/semantic/bovine/gcc.el > Should these tests perhaps be consolidated somehow? Maybe, or at least be written identically. I don't know if there is a suitable place to put an auxiliary function like this. More importantly, both should probably use the same detection pattern. Do the flymake tests fail on Monterey? ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang 2022-01-02 16:30 ` Mattias Engdegård @ 2022-01-02 16:46 ` Stefan Kangas 2022-01-02 18:34 ` Stefan Kangas 2022-01-02 18:12 ` Eli Zaretskii 1 sibling, 1 reply; 7+ messages in thread From: Stefan Kangas @ 2022-01-02 16:46 UTC (permalink / raw) To: Mattias Engdegård; +Cc: emacs-devel Mattias Engdegård <mattiase@acm.org> writes: > 2 jan. 2022 kl. 16:11 skrev Stefan Kangas <stefankangas@gmail.com>: > >> We have a similar check in test/lisp/cedet/semantic/bovine/gcc.el > >> Should these tests perhaps be consolidated somehow? > > Maybe, or at least be written identically. I don't know if there is a > suitable place to put an auxiliary function like this. subr-x.el, perhaps? > More importantly, both should probably use the same detection > pattern. Do the flymake tests fail on Monterey? I don't use Monterey, so I can't check. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang 2022-01-02 16:46 ` Stefan Kangas @ 2022-01-02 18:34 ` Stefan Kangas 0 siblings, 0 replies; 7+ messages in thread From: Stefan Kangas @ 2022-01-02 18:34 UTC (permalink / raw) To: Mattias Engdegård; +Cc: emacs-devel Stefan Kangas <stefankangas@gmail.com> writes: > subr-x.el, perhaps? Sorry, I meant ert-x.el. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang 2022-01-02 16:30 ` Mattias Engdegård 2022-01-02 16:46 ` Stefan Kangas @ 2022-01-02 18:12 ` Eli Zaretskii 2022-01-02 19:04 ` Stefan Monnier 1 sibling, 1 reply; 7+ messages in thread From: Eli Zaretskii @ 2022-01-02 18:12 UTC (permalink / raw) To: Mattias Engdegård; +Cc: stefankangas, emacs-devel > From: Mattias Engdegård <mattiase@acm.org> > Date: Sun, 2 Jan 2022 17:30:53 +0100 > Cc: emacs-devel@gnu.org > > 2 jan. 2022 kl. 16:11 skrev Stefan Kangas <stefankangas@gmail.com>: > > > We have a similar check in test/lisp/cedet/semantic/bovine/gcc.el > > > Should these tests perhaps be consolidated somehow? > > Maybe, or at least be written identically. I don't know if there is a suitable place to put an auxiliary function like this. subr.el, probably. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang 2022-01-02 18:12 ` Eli Zaretskii @ 2022-01-02 19:04 ` Stefan Monnier 2022-01-02 19:42 ` Eli Zaretskii 0 siblings, 1 reply; 7+ messages in thread From: Stefan Monnier @ 2022-01-02 19:04 UTC (permalink / raw) To: Eli Zaretskii; +Cc: Mattias Engdegård, stefan, emacs-devel Eli Zaretskii [2022-01-02 20:12:31] wrote: >> Maybe, or at least be written identically. I don't know if there is >> a suitable place to put an auxiliary function like this. > subr.el, probably. That would mean the function is preloaded, whereas we're talking here about code that's only used in our test suite, which doesn't seem to justify preloading it. Stefan ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang 2022-01-02 19:04 ` Stefan Monnier @ 2022-01-02 19:42 ` Eli Zaretskii 0 siblings, 0 replies; 7+ messages in thread From: Eli Zaretskii @ 2022-01-02 19:42 UTC (permalink / raw) To: Stefan Monnier; +Cc: mattiase, stefan, emacs-devel > From: Stefan Monnier <monnier@iro.umontreal.ca> > Cc: Mattias Engdegård <mattiase@acm.org>, > stefan@marxist.se, > emacs-devel@gnu.org > Date: Sun, 02 Jan 2022 14:04:18 -0500 > > Eli Zaretskii [2022-01-02 20:12:31] wrote: > >> Maybe, or at least be written identically. I don't know if there is > >> a suitable place to put an auxiliary function like this. > > subr.el, probably. > > That would mean the function is preloaded, whereas we're talking here > about code that's only used in our test suite, which doesn't seem to > justify preloading it. I envision the need to make these checks not just in the test suite. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-01-02 19:42 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <164112836156.3693.5253778017552372948@vcs2.savannah.gnu.org> [not found] ` <20220102125921.CEC93C0DA1A@vcs2.savannah.gnu.org> 2022-01-02 15:11 ` master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang Stefan Kangas 2022-01-02 16:30 ` Mattias Engdegård 2022-01-02 16:46 ` Stefan Kangas 2022-01-02 18:34 ` Stefan Kangas 2022-01-02 18:12 ` Eli Zaretskii 2022-01-02 19:04 ` Stefan Monnier 2022-01-02 19:42 ` Eli Zaretskii
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.