From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#45333: complex command history should not save optional nil parameters Date: Thu, 07 Jul 2022 09:58:29 -0400 Message-ID: References: <0DJzRuBn1S9jW_MoJt5HXcLQWrzb7Vjkfmlwa9zPvgLIFeEfdPLoiguSztbL4TnuHyxd59Z7BpS9qJo5BinMO3n1mDlWjcytLjq9HmoGIl0=@protonmail.com> <8735ggk7nz.fsf@gnus.org> <83ee007gxo.fsf@gnu.org> <87o7z3bcsp.fsf@gnus.org> <875ykbabl1.fsf@web.de> <87o7y31pho.fsf@gnus.org> <87wncrs8js.fsf@web.de> <87sfnfmm41.fsf@gnus.org> <87k08rs7jg.fsf@web.de> <87bku3ml4x.fsf@gnus.org> <87fsjfs5v2.fsf@web.de> <871quzmj9a.fsf@gnus.org> <87o7y3l1xm.fsf@gnus.org> <87v8s9idnx.fsf@gnus.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30324"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Michael Heerdegen , laszlomail@protonmail.com, Eli Zaretskii , 45333@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 07 15:59:08 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9S28-0007Xa-Bp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jul 2022 15:59:08 +0200 Original-Received: from localhost ([::1]:53520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9S27-0000Lj-2H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jul 2022 09:59:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9S22-0000Lb-4S for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 09:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35339) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9S21-0004Yo-Ra for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 09:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9S21-00042u-RK for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 09:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jul 2022 13:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45333 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 45333-submit@debbugs.gnu.org id=B45333.165720232015520 (code B ref 45333); Thu, 07 Jul 2022 13:59:01 +0000 Original-Received: (at 45333) by debbugs.gnu.org; 7 Jul 2022 13:58:40 +0000 Original-Received: from localhost ([127.0.0.1]:57469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9S1g-00042G-EP for submit@debbugs.gnu.org; Thu, 07 Jul 2022 09:58:40 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9S1e-000422-8z for 45333@debbugs.gnu.org; Thu, 07 Jul 2022 09:58:38 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D2D90100163; Thu, 7 Jul 2022 09:58:32 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 246F6100130; Thu, 7 Jul 2022 09:58:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1657202311; bh=M07mbYr3on2KNamcyZ4NDJ3jzNOU01yHgeS4wEhzIOY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GqIfzqlD1pmRCT/1S6hJncvb/ZNMggY/Qd5C3pQHx/Ens/NU8c5lkUZgKMGoPpi+j nqXkDkvrfu5iB4AiPFCW66ceXpTb7Hi8Aq+6A/++pVNgdrSgDglfaKVETGElJWsFUm s4yVciOR7jYk9HiKeyEYCQR80ijAuiUOfzO/hxmjidh3ab+3FUuqyCLtdbicApCmW4 F7Ym3CtD1twtsnye0D8f8w6oVV5AQAMA+rIgZWFemAJhRtbqn/qAwBhoXlK2U2QlVq OvQgmKriH/cVqKeVjMSs4vdkTceN0FyIiayA/4HuOb+ixkHhWIA0j1Gjl6vowQ5T4X k3VcYXGkaEw6A== Original-Received: from pastel (unknown [45.72.196.165]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id D87501204A0; Thu, 7 Jul 2022 09:58:30 -0400 (EDT) In-Reply-To: <87v8s9idnx.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 07 Jul 2022 09:29:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236368 Archived-At: >> OClosure or not doesn't make much of a difference here, I think (the >> previous version of the code would also be quite hideous in C). >> Why not just call `advice--cd*r`? > Sure, that's possible, but just seems a bit backwards. Don't know about backward, but if you don't like that dependency, you could break it using a hook, like a `function-unwrap-function` whose default value is `identity` and which `nadvice.el` could change to `advice-cd*r`. Stefan