From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 35d5ad713e 1/3: Rewrite wallpaper.el to use a cl-defstruct Date: Mon, 26 Sep 2022 12:37:45 -0400 Message-ID: References: <166420698826.28980.18372659877071995219@vcs2.savannah.gnu.org> <20220926154308.D7533C0CD93@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14639"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Sep 26 19:02:46 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ocrVG-0003fL-Cb for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Sep 2022 19:02:46 +0200 Original-Received: from localhost ([::1]:37386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ocrVF-00016k-7x for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Sep 2022 13:02:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53502) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocr7A-00018u-TC for emacs-devel@gnu.org; Mon, 26 Sep 2022 12:37:54 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:40297) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocr77-00007h-MB for emacs-devel@gnu.org; Mon, 26 Sep 2022 12:37:51 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2CC8B440C2D; Mon, 26 Sep 2022 12:37:47 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E163F440BE3; Mon, 26 Sep 2022 12:37:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1664210265; bh=jHAwmicq9HnV+gpcEsHUIqgZ4NMfMHHyHqn0cgeG4mQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=HIZVxHYkc6qNZQdcrA6AqbYHda6oRmjsQL8FPN1hIeXV8yLhOe5OJiajF+z7qQ1Dp gO/LZjs/aPfG89vlURlXFwcyMmysQXV1my9OC1hQQqpkvscjJfIZDtjYL4tppLPyyC aW17ZkwTfukQqMAHwpFJaJoHwZ2ubYAeBH6Vrgv/K1QRpFwqBlQiPCUqUvnUXzQDjI 759toEYuRltLHN4mWZX0D0X55z10NlwXT+gFc7fDaibf0aA9IfjAQfJwRYhhB0vVAt Vpgak43mqraYSccDurKEm5T/kiSvBB9k/icdKM9H9VuCTBmwFUNddm+k+D1NrVcLUa Zk1T9wsGR0DfQ== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CEB4F120840; Mon, 26 Sep 2022 12:37:45 -0400 (EDT) In-Reply-To: <20220926154308.D7533C0CD93@vcs2.savannah.gnu.org> (Stefan Kangas's message of "Mon, 26 Sep 2022 11:43:08 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296290 Archived-At: > +(cl-defstruct (wallpaper-setter > + ;; Rename the default constructor from `make-wallpaper-cmd'. > + (:constructor > + wallpaper-setter-create > + ( name command args-raw > + &rest rest-plist > + &aux > + (args (if (listp args-raw) > + args-raw > + (string-split args-raw))) > + (predicate (plist-get rest-plist :predicate)))) FWIW, the above does not "rename" anything. It just adds another constructor in addition to the default `make-wallpaper-cmd`. If you don't want that default (I never want it, personally), then you need to add (:constructor nil) to your `cl-defstruct`. Stefan