From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict Date: Mon, 30 Jan 2023 16:00:51 -0500 Message-ID: References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3884"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: larsi@gnus.org, 61184@debbugs.gnu.org, rpluim@gmail.com To: Daniel Mendler Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 30 22:05:00 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMbKl-0000jh-Lj for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Jan 2023 22:04:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMbHy-0003VJ-5Q; Mon, 30 Jan 2023 16:02:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMbHv-0003Qr-27 for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 16:02:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMbHu-0005mb-N5 for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 16:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMbHu-0006mF-4V for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 16:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jan 2023 21:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61184 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: Lars Ingebrigtsen , bug-gnu-emacs@gnu.org, Robert Pluim Original-Received: via spool by submit@debbugs.gnu.org id=B.167511246525980 (code B ref -1); Mon, 30 Jan 2023 21:02:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 Jan 2023 21:01:05 +0000 Original-Received: from localhost ([127.0.0.1]:50705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMbGz-0006kv-Dm for submit@debbugs.gnu.org; Mon, 30 Jan 2023 16:01:05 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:51590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMbGw-0006kn-VG for submit@debbugs.gnu.org; Mon, 30 Jan 2023 16:01:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMbGu-0001zP-Nt for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 16:01:02 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMbGr-0005f5-UZ for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 16:01:00 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9A6724417B7; Mon, 30 Jan 2023 16:00:55 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2248C4417B5; Mon, 30 Jan 2023 16:00:54 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1675112454; bh=/VRAgblkbTlNe4Jx0q+nv9/hUh4EkHzfo74N8j+GEPU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=bRlvNDT2bw6y/Gh00gULtVKzTNKHmbqI8zSx1uRDVD5ToY0evefhzQeot2AxtPoGS ZUkoIOXLKth4W2C/H9fY9mC3SQXp3lZbwNhNAyrxX9EJpW5TiyPrlg7s+h7JD7E/iu LcSN5359jv7p/Pb/VlZP8A9FY9364jRccqbt2zvQUmFru92vS7cr6k5XiCzSF20xTJ uPTrg1tH6Z6JaaytJtdXOkhoTPoXUHNPmgR4TUAXVuY/hKlp6zkdj5dyS1ffTzymk7 wTC7xgB7BqzKkcYsSJq6xKPH1ADFKmIgB0/fykRxChpWwTkShkdomm60rrsJbrzr02 RaIRXVMfK2Wqw== Original-Received: from pastel (unknown [45.72.238.67]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DF85C121319; Mon, 30 Jan 2023 16:00:53 -0500 (EST) In-Reply-To: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> (Daniel Mendler's message of "Mon, 30 Jan 2023 21:52:54 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254480 Archived-At: > In patch f67a9a12b7b0cdd6030cb080a6d6838255789a08, the commands > keymap-local-set and keymap-global-set became less strict for > non-interactive use, which is not the intended the design. The goal is > that the API only accepts strings in a single format. The vector to > string conversion should happen within the interactive form. I don't see any use for the vector->string conversion to happen in the interactive spec: I think the most important use cases for accepting vectors is when these come directly from Lisp, in which case having to convert them back to the KBD syntax (only to hope `key-parse` will correctly undo the damage) is just a waste and a hurdle. > There was an old commit by Stefan Monnier, where he relaxed the API, but > Lars made it clear back then that it is better to only accept a single > format for the keymap API, such that guidance for the user is better due > to clear error messages. Obviously, I disagree: the vector format is not going anywhere, so it makes a lot sense to accept it, even though I fully agree that guidance should never suggest the use of the vector format. Stefan