From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs,gmane.emacs.orgmode Subject: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Tue, 09 Jan 2024 11:48:24 -0500 Message-ID: References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83cyyw4of7.fsf@gnu.org> <875y4ovct9.fsf@localhost> <875y04yq9s.fsf@localhost> <878r4yy2wu.fsf@localhost> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15138"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-orgmode@gnu.org, Eli Zaretskii , 65734@debbugs.gnu.org, Max Nikulin , iota@whxvd.name To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 09 17:49:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNFI1-0003fo-A7 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Jan 2024 17:49:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNFHf-0003Gg-C8; Tue, 09 Jan 2024 11:48:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNFHb-0003Fs-8i for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 11:48:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNFHb-0008KU-0Q for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 11:48:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNFHh-0006a6-Jc for bug-gnu-emacs@gnu.org; Tue, 09 Jan 2024 11:49:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Jan 2024 16:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65734 X-GNU-PR-Package: emacs Original-Received: via spool by 65734-submit@debbugs.gnu.org id=B65734.170481892125189 (code B ref 65734); Tue, 09 Jan 2024 16:49:01 +0000 Original-Received: (at 65734) by debbugs.gnu.org; 9 Jan 2024 16:48:41 +0000 Original-Received: from localhost ([127.0.0.1]:40766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNFHM-0006YB-Py for submit@debbugs.gnu.org; Tue, 09 Jan 2024 11:48:41 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNFHL-0006XS-JC for 65734@debbugs.gnu.org; Tue, 09 Jan 2024 11:48:40 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2692380DB3; Tue, 9 Jan 2024 11:48:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1704818906; bh=xKY2a275EZsnbx13QiOhunmJ8ldGEzGhXN7G0Eb4X5A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BVmGYr7+JXWcPEuYmBQE+wIUrEJX5vlGY4HupgGJgVayXz2nEC1b+8h8ROpixVLG0 z8N3dRA8IoWMW78qf4Wqer+/usShG0Ge2BQJNlbpzxVMjSU6p6dBaVjuGsYuyv4Mrq A2fNc0j6RhKndQYJT3+bdQjl3bt0FmGtgxpSLldUxlpBfjKEG6P5xOaI6AF8iQqs6+ cuOYPcBsIlzZsYjY/PNHvNRkZeQyYpMAJWM44mLUuY8mIFtLogqTXbVn5o2geS8NO/ SJbh3Hixh9+yfUHsWFHS0886XTLpviKHfgLkn2OqCeGBXhi9ew7a3zyKo+OGCQq1Y7 tZ58HwwzXX5gw== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F230B80CC9; Tue, 9 Jan 2024 11:48:25 -0500 (EST) Original-Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AE6F6120426; Tue, 9 Jan 2024 11:48:25 -0500 (EST) In-Reply-To: <878r4yy2wu.fsf@localhost> (Ihor Radchenko's message of "Tue, 09 Jan 2024 14:52:49 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277636 gmane.emacs.orgmode:158941 Archived-At: >> That's why I said "rule of thumb": there can be tradeoffs. >> In practice 99% of Emacs commands modify only a single contiguous chunk >> of text, so the tradeoff comes into play fairly rarely. > It would be nice if this advice were added to the relevant docstrings. Not sure exactly which advice you're referring to (the text you quoted above is misleading: it would encourage the naive reader to just do the work in `after-change-functions` since it's called only once per command anyway, which they already instinctively do and which is exactly what we don't want), nor which docstring you're referring to. Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:5f26::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id mLzSChl5nWXx6wAAkFu2QA (envelope-from ) for ; Tue, 09 Jan 2024 17:49:29 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id eFM5BRl5nWUokQAAqHPOHw (envelope-from ) for ; Tue, 09 Jan 2024 17:49:29 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=iro.umontreal.ca header.s=mail header.b=BVmGYr7+; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=iro.umontreal.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1704818968; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=HF69g6A1VqeEHZIS/NOUmviIgQ8nOmizCfd1ImPlxTA=; b=N/hgmBO2ZJC6ivdzxhjjVvXDS+T+NURdep3AV+RqpR0kILlLKbztd+WHIhkzb9P8sr6Dcj WzHFcrg3RFfLi9wFyVyqCwGp+neh1n1BfPnaqKCQTXibdN3Frxpwwb5xpc7zemIJkNNRzw R9uocia7J7sTSQPtalbXFNQXjFyGLo6QOHdnrwmS2qjI2ZJGRs4zplUjqIaCZtuJxX8ST7 dq23TWV/ynckNyybgVCPSQwwnBJqETtG0qXt9dghrQfH1R+2qpwdUC8SFBRynbC4s9HJDv Zw/P750Jlp7hyP2YOrSIlYe+qW2nqjlc+5/YM5I6oc2DWsCGGEEYaQrcehhlIQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1704818968; a=rsa-sha256; cv=none; b=iJFQsi063toCvchvcdRXLMEXyO2k6qWsCJC7iANCnhL1nfxOoVtcrJ0FVhRfsoTsXc6asP nSapi4rpj/P5uMLGzBZK1NIZ7hXHExy7Fhw3b4pCwYAMnjihp23iIFG7FJeg473nLFm1kQ wWccADpk0KjDihSHurfVVT0yH5991niwKCgPNQdSMB6Ekcb5LLE/pXXkmjafTJgf1umfEd iTLMPv7TKnaqzsZRulC7Lgoapm1bjKHtXKBP30YjpDGZGBHTYhj+pTMvZ9zmZ07Y02RfIQ 1N8OFiAQunJqJQFrNyU++0CH0NH8t4lnWi5KRSNWOlbZnNucB8YjTqnFlTVy9Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=iro.umontreal.ca header.s=mail header.b=BVmGYr7+; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=quarantine) header.from=iro.umontreal.ca Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 624DE76CEC for ; Tue, 9 Jan 2024 17:49:28 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNFHI-0003Eh-Em; Tue, 09 Jan 2024 11:48:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNFHF-0003EI-Qq for emacs-orgmode@gnu.org; Tue, 09 Jan 2024 11:48:34 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNFHD-00083e-58; Tue, 09 Jan 2024 11:48:32 -0500 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 2692380DB3; Tue, 9 Jan 2024 11:48:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1704818906; bh=xKY2a275EZsnbx13QiOhunmJ8ldGEzGhXN7G0Eb4X5A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BVmGYr7+JXWcPEuYmBQE+wIUrEJX5vlGY4HupgGJgVayXz2nEC1b+8h8ROpixVLG0 z8N3dRA8IoWMW78qf4Wqer+/usShG0Ge2BQJNlbpzxVMjSU6p6dBaVjuGsYuyv4Mrq A2fNc0j6RhKndQYJT3+bdQjl3bt0FmGtgxpSLldUxlpBfjKEG6P5xOaI6AF8iQqs6+ cuOYPcBsIlzZsYjY/PNHvNRkZeQyYpMAJWM44mLUuY8mIFtLogqTXbVn5o2geS8NO/ SJbh3Hixh9+yfUHsWFHS0886XTLpviKHfgLkn2OqCeGBXhi9ew7a3zyKo+OGCQq1Y7 tZ58HwwzXX5gw== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id F230B80CC9; Tue, 9 Jan 2024 11:48:25 -0500 (EST) Received: from pastel (65-110-221-238.cpe.pppoe.ca [65.110.221.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AE6F6120426; Tue, 9 Jan 2024 11:48:25 -0500 (EST) From: Stefan Monnier To: Ihor Radchenko Cc: Eli Zaretskii , 65734@debbugs.gnu.org, Max Nikulin , emacs-orgmode@gnu.org, iota@whxvd.name Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] In-Reply-To: <878r4yy2wu.fsf@localhost> (Ihor Radchenko's message of "Tue, 09 Jan 2024 14:52:49 +0000") Message-ID: References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83cyyw4of7.fsf@gnu.org> <875y4ovct9.fsf@localhost> <875y04yq9s.fsf@localhost> <878r4yy2wu.fsf@localhost> Date: Tue, 09 Jan 2024 11:48:24 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 624DE76CEC X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -9.63 X-Spam-Score: -9.63 X-TUID: qeUczRe1tOQQ >> That's why I said "rule of thumb": there can be tradeoffs. >> In practice 99% of Emacs commands modify only a single contiguous chunk >> of text, so the tradeoff comes into play fairly rarely. > It would be nice if this advice were added to the relevant docstrings. Not sure exactly which advice you're referring to (the text you quoted above is misleading: it would encourage the naive reader to just do the work in `after-change-functions` since it's called only once per command anyway, which they already instinctively do and which is exactly what we don't want), nor which docstring you're referring to. Stefan