From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72696: Track-changes errors out when file is overwritten using Node.js's fs.writeFile (at least on macOS) Date: Fri, 20 Sep 2024 14:46:43 -0400 Message-ID: References: <86a5g49pju.fsf@gnu.org> <86ttea7sl6.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40232"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 72696@debbugs.gnu.org, dario.gjorgjevski@gmail.com, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 20 20:48:08 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1srifn-000AJQ-Vp for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Sep 2024 20:48:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1srifR-0004xc-B6; Fri, 20 Sep 2024 14:47:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1srifQ-0004xO-10 for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2024 14:47:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1srifP-0008Hp-LL for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2024 14:47:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=z/QK9cjnC7r20VIvSQ1F977vEnjRQpXFJIpI3eDgpW0=; b=gPSlmVDYGq4Jl2URn8snMsMzBp4Kv5eXN5esQZ/qiROsfWyru/sXZAHbHxiRMp1okZL7iUnpCki3eYeQZxyC6inBXPsIgjWGrmtvYj5t1NnYEzKbXqDJcQu5z+pUGv8GaL2niJawUGJXViaNCKJIBMPVW4qYD++/xofm0MTSjQ5Sz547GEHLJaZbrNzTYJGa/RICHY4wPRi/8Z4n0LK0Psg4YBcKzaAOfDG7E+VzIbhT/isGYKI9+G83PUPduPiY82MVAhog17e4PKJ/y7yEVM531pDlts4SJTJ98L7vcUywl1rGEwdUPzilZ7Ul7QY+HCGYH2U4gPwe1WHES86bSQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1srifi-00053S-E9 for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2024 14:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2024 18:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72696 X-GNU-PR-Package: emacs Original-Received: via spool by 72696-submit@debbugs.gnu.org id=B72696.172685803419359 (code B ref 72696); Fri, 20 Sep 2024 18:48:02 +0000 Original-Received: (at 72696) by debbugs.gnu.org; 20 Sep 2024 18:47:14 +0000 Original-Received: from localhost ([127.0.0.1]:36346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sriev-00052A-J8 for submit@debbugs.gnu.org; Fri, 20 Sep 2024 14:47:13 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33273) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sries-00051s-TY for 72696@debbugs.gnu.org; Fri, 20 Sep 2024 14:47:11 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id CB697100044; Fri, 20 Sep 2024 14:46:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1726858004; bh=xlMk84si/Z7fgum+zndAcRV8guNnj6+f7b5b5eWe4p4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=oH6aLmBqgnehCTf/IGtiq2uBICNF0RbK0J4F6N80F2I/H6Wp8ynpofmY1TCvtO5o6 CCaJz6e4rreeCRkKmd8AZA+Mx8VbjV+aldhO8q56n97WsLtcwSoQKVZaB3fm/LA+bJ FbhwQLepzPSV34maynLE/Io5uTQNYvZdfO+zbtmyXMTsZgIlpxytZo3GWasPylHOJ4 4xeLrQiquiNb9dklSmPvI2zN/hn0om1bd0Jl6ZTrJ4zOiDlfBc0KKYmFpuNk5kmNYi e7sT1g0XtS8C4pF9pcTPW9k/FS8l4dpsubseKjIFixh+wcZyuR8vK4YTEY+bigPguG II++OQ9mjKFbA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A31F8100035; Fri, 20 Sep 2024 14:46:44 -0400 (EDT) Original-Received: from asado (modemcable031.210-178-173.mc.videotron.ca [173.178.210.31]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 75DF912022A; Fri, 20 Sep 2024 14:46:44 -0400 (EDT) In-Reply-To: <86ttea7sl6.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 20 Sep 2024 09:21:57 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292133 Archived-At: >> You can go ahead and merge it. I dont' know what it does >> but i trust Stefan. > Thanks. Stefan, please install on the emacs-30 branch. Thanks, done. > I agree with your general feeling, and I think this case might belong > to those pre-existing failures which track-changes uncovers. FWIW, I think this bug was one that I introduced when changing Eglot to use track-changes (basically, because track-changes does its own "buffering" in addition to the one Eglot does in `eglot--recent-changes`, and I forgot to flush that buffer when `eglot--recent-changes` is flushed). Stefan