From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74461: [PATCH] Add go-work-ts-mode Date: Sun, 22 Dec 2024 10:33:27 -0500 Message-ID: References: <87ttbzd16p.fsf@disroot.org> <86jzcl81py.fsf@gnu.org> <877c8l55he.fsf@disroot.org> <1C8B596E-785F-435D-AFEA-A2382FDA6AD8@disroot.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25544"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: dev@rjt.dev, Eli Zaretskii , 74461@debbugs.gnu.org To: Gabriel Santos Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 22 16:34:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tPNyL-0006Rk-HA for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Dec 2024 16:34:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tPNy2-0000r3-DH; Sun, 22 Dec 2024 10:34:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPNxy-0000qm-W0 for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 10:34:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tPNxy-000550-O2 for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 10:34:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=JJVVR5bPNTS7RdUyME/pWYJs6jxxs1m9r8NyP5F/gX0=; b=CUVd3uz5SUBuaILrv4yOLODIrxj+3IWsO4v4raoxB/0usH5b1k1XIXnO19eaj5C4nZK8HurUL04vIreU9MFq6j/A/LeRVnHloIRjhhkRUF8RKqDJrCb4Z3eYVciZVH8giyZbzOjA2WdZZvpp/O07ihawa6U3/L0n3Cc/rqVHx98PFYQQfRtgkR53MKV4zLnvcAa6EntYFTlJ22l8W9Una37nRIONYW4vw/nibAx9/S18xA1TBjcWMRUxM5UW4WOQ8GAW7kPKS0z9NUP3ovmaBBia41cBRo8NMwl0tY79XZSBHOH5YByMlen9mC3g6ceeNs12/kyQvtXY26WuVqlKWw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tPNxy-0002GY-9N for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 10:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Dec 2024 15:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74461 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74461-submit@debbugs.gnu.org id=B74461.17348816208677 (code B ref 74461); Sun, 22 Dec 2024 15:34:02 +0000 Original-Received: (at 74461) by debbugs.gnu.org; 22 Dec 2024 15:33:40 +0000 Original-Received: from localhost ([127.0.0.1]:51491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPNxc-0002Fs-0h for submit@debbugs.gnu.org; Sun, 22 Dec 2024 10:33:40 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:16031) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPNxY-0002Fd-5W for 74461@debbugs.gnu.org; Sun, 22 Dec 2024 10:33:38 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 50D1210004C; Sun, 22 Dec 2024 10:33:30 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1734881608; bh=eBVkS2zJNbvgscBPpWulDSE8r5a+yFuqyR7Y4QZxxjg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=H6RC9i3AvQeX0go3P6FObGn6w2aOelqpB3jWCA01EZhuWkEg6XrO2lthhJS5/WdXh JddohmghmmbIFhJEXLeBevA3ZkTawnAsPePgDyOntSuWz1NFwftnC69DxGXMFU/YV9 IhM3lTKd1Wx+uPxFldcKEQqoiQT7NRtWzHS5Wl91c5RtkBnS1Fc4GEeTdK3uxhrdmI lxiAi9YUkv3YacRAuYKt/d2rzRg54C2S8sZm6vTzpvNEmsI10oVjkxjwSWjE7nIccW mVg7d6WRnUzw/bdJdveFdPu2DkH8//q8UrQDAA3KhaDnPGBBcdj2bP6EOQRGgu0Bot Ns73pmmHGq+Ag== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D4BA1100042; Sun, 22 Dec 2024 10:33:28 -0500 (EST) Original-Received: from asado (unknown [199.119.74.1]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9118C120635; Sun, 22 Dec 2024 10:33:28 -0500 (EST) In-Reply-To: <1C8B596E-785F-435D-AFEA-A2382FDA6AD8@disroot.org> (Gabriel Santos's message of "Sun, 22 Dec 2024 08:32:39 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297603 Archived-At: >>Do we have a way to tell Eglot which LSP server(s) to use via some >>buffer-local var, instead of having to change this centralized >>"database"? > > Looking at the following commits: > > - 5f56bc1 > > - e37754f > > > That doesn't seem to be the case. It was a kind of rethorical question: whether we do or not, we *should* have such a mechanism and we should use it here. > Go uses tabs for indentation, > and spaces for alignment. [...] > The language specification doesn't mention > that, but I think it should. > Maybe I should send them an e-mail about that. I don't think the language cares (or should care). It's only a convention. But if it's the only convention in use in Go, that's fine: just add a link to https://go.dev/doc/effective_go#formatting that justifies the setting. >>Since we don't have another (non-treesitter) mode for these files, I'd >>recommend you go straight for: >> >> ;;;###autoload >> (add-to-list 'auto-mode-alist '("/go\\.work\\'" . go-work-ts-mode)) > > > Sorry if I misunderstand, > but that doesn't seem to be the case > for other tree-sitter modes. Past practice does not always reflect best practices, especially when talking about relatively new practices. Stefan