From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: diff-apply-hunk documentation doesn't match implementation Date: Sun, 11 Mar 2007 17:54:08 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1173650071 8598 80.91.229.12 (11 Mar 2007 21:54:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 11 Mar 2007 21:54:31 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 11 22:54:25 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HQVzi-0001y5-Qv for ged-emacs-devel@m.gmane.org; Sun, 11 Mar 2007 22:54:23 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HQW0I-0000zn-UF for ged-emacs-devel@m.gmane.org; Sun, 11 Mar 2007 16:54:58 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HQW07-0000zh-VM for emacs-devel@gnu.org; Sun, 11 Mar 2007 17:54:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HQW06-0000zF-QS for emacs-devel@gnu.org; Sun, 11 Mar 2007 17:54:47 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HQW06-0000zC-Mn for emacs-devel@gnu.org; Sun, 11 Mar 2007 16:54:46 -0500 Original-Received: from tomts20.bellnexxia.net ([209.226.175.74] helo=tomts20-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HQVzV-0006DB-PD for emacs-devel@gnu.org; Sun, 11 Mar 2007 17:54:09 -0400 Original-Received: from pastel.home ([74.12.204.225]) by tomts20-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20070311215408.XLQM1637.tomts20-srv.bellnexxia.net@pastel.home> for ; Sun, 11 Mar 2007 17:54:08 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 7DBF57F26; Sun, 11 Mar 2007 17:54:08 -0400 (EDT) In-Reply-To: (Andreas Schwab's message of "Sun\, 11 Mar 2007 13\:00\:25 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.95 (gnu/linux) X-detected-kernel: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67745 Archived-At: > The doc string of diff-apply-hunk says: > By default, the new source file is patched, but if the variable > `diff-jump-to-old-file' is non-nil, then the old source file is > patched instead > But the implementation then goes on to do the opposite: > ;; If REVERSE go to the new file, otherwise go to the old. > (diff-find-source-location (not reverse) reverse) This is just one part of the implementation. The behavior is actually pretty subtle (too subtle, admittedly). So I can't judge without knowing which end-user-level behavior you're referring to. I.e. give me a recipe. Stefan