From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: log-view.el calls non-existent function vc-version-diff Date: Sat, 13 Oct 2007 22:07:58 -0400 Message-ID: References: <200710131744.l9DHiL4Z023009@oogie-boogie.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1192327710 29349 80.91.229.12 (14 Oct 2007 02:08:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 14 Oct 2007 02:08:30 +0000 (UTC) Cc: "Eric S. Raymond" , emacs-pretest-bug@gnu.org, Chris Moore To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 14 04:08:20 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Igstt-0004SF-Oy for ged-emacs-devel@m.gmane.org; Sun, 14 Oct 2007 04:08:18 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Igstn-0005Pg-0c for ged-emacs-devel@m.gmane.org; Sat, 13 Oct 2007 22:08:11 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Igsti-0005PB-B9 for emacs-devel@gnu.org; Sat, 13 Oct 2007 22:08:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Igstf-0005Oz-VG for emacs-devel@gnu.org; Sat, 13 Oct 2007 22:08:05 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Igstf-0005Ow-Od for emacs-devel@gnu.org; Sat, 13 Oct 2007 22:08:03 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Igstf-0007BF-ET for emacs-devel@gnu.org; Sat, 13 Oct 2007 22:08:03 -0400 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Igstf-0003me-8t for emacs-pretest-bug@gnu.org; Sat, 13 Oct 2007 22:08:03 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Igstc-0007Ax-MU for emacs-pretest-bug@gnu.org; Sat, 13 Oct 2007 22:08:03 -0400 Original-Received: from simmts7.bellnexxia.net ([206.47.199.165] helo=simmts7-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Igstc-0007Ah-B4 for emacs-pretest-bug@gnu.org; Sat, 13 Oct 2007 22:08:00 -0400 Original-Received: from ceviche.home ([70.55.141.81]) by simmts7-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20071014020759.BUSL28304.simmts7-srv.bellnexxia.net@ceviche.home> for ; Sat, 13 Oct 2007 22:07:59 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id E4A61B41BB; Sat, 13 Oct 2007 22:07:58 -0400 (EDT) In-Reply-To: <200710131744.l9DHiL4Z023009@oogie-boogie.ics.uci.edu> (Dan Nicolaescu's message of "Sat\, 13 Oct 2007 10\:44\:21 -0700") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Solaris 8 (1) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80834 gmane.emacs.pretest.bugs:20123 Archived-At: >> The only 2 references to vc-version-diff in the whole lisp/ tree are: >> >> ./log-view.el:(autoload 'vc-version-diff "vc") >> ./log-view.el: (vc-version-diff (log-view-current-file) to fr))) > It seems that it should be changed to call vc-history-diff. > But vc-history-diff takes a `backend' parameter. But it computes the > backend in the code anyway... > ESR, can you please say what is your intention with that function? > Should it just lose the `backend' parameter? In any case, vc.el should provide a backward compatibility definition of vc-version-diff (and mark it obsolete). Stefan