From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Yanking isearch to highlight-regexp Date: Sun, 29 Jun 2008 14:07:39 -0400 Message-ID: References: <4853F884.7000609@gmail.com> <7dbe73ed0806141442h342f8ff0u83863f3980a7e229@mail.gmail.com> <48545D78.8080103@gmail.com> <4854E536.8040407@gmail.com> <87k5gql900.fsf@jurta.org> <878wwp1an8.fsf@jurta.org> <871w2gi58m.fsf@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1214762872 9744 80.91.229.12 (29 Jun 2008 18:07:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 Jun 2008 18:07:52 +0000 (UTC) Cc: David Koppelman , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 29 20:08:38 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KD1KG-0007HD-Vy for ged-emacs-devel@m.gmane.org; Sun, 29 Jun 2008 20:08:37 +0200 Original-Received: from localhost ([127.0.0.1]:50983 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KD1JQ-0007Cb-S6 for ged-emacs-devel@m.gmane.org; Sun, 29 Jun 2008 14:07:44 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KD1JN-0007CM-Ti for emacs-devel@gnu.org; Sun, 29 Jun 2008 14:07:41 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KD1JN-0007CA-3u for emacs-devel@gnu.org; Sun, 29 Jun 2008 14:07:41 -0400 Original-Received: from [199.232.76.173] (port=55192 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KD1JN-0007C7-0K for emacs-devel@gnu.org; Sun, 29 Jun 2008 14:07:41 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.182]:33803) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KD1JM-0007Ab-Lo for emacs-devel@gnu.org; Sun, 29 Jun 2008 14:07:40 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjQFAC1sZ0hFxIdG/2dsb2JhbACBW6xtgXo X-IronPort-AV: E=Sophos;i="4.27,723,1204520400"; d="scan'208";a="23741110" Original-Received: from 69-196-135-70.dsl.teksavvy.com (HELO pastel.home) ([69.196.135.70]) by ironport2-out.teksavvy.com with ESMTP; 29 Jun 2008 14:07:40 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id EACD0835A; Sun, 29 Jun 2008 14:07:39 -0400 (EDT) In-Reply-To: <871w2gi58m.fsf@jurta.org> (Juri Linkov's message of "Sun, 29 Jun 2008 19:19:05 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:100149 Archived-At: > Now here is a patch for hi-lock.el that uses `read-regexp'. > It also marks `hi-lock-regexp-history' as an obsolete variable > that is replaced with `regexp-history'. Sounds good. > Another change is renaming `hi-lock-face-history' to > `hi-lock-face-defaults' and putting the face list to the > minibuffer's default list instead of the history list: Why is that good? > (try-completion > ! (substring (car hi-lock-face-history) 0 1) > (mapcar (lambda (f) (cons f f)) > ! hi-lock-face-history)))) I believe the "(mapcar (lambda (f) (cons f f))" can be removed, since try-completion accepts lists of strings since Emacs-21 IIRC. Stefan