From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: url-get-url-at-point & url-get-url-filename-chars | comma-p Date: Sat, 21 Mar 2009 21:18:15 -0400 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1237684696 4881 80.91.229.12 (22 Mar 2009 01:18:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Mar 2009 01:18:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: "S+*n_Pe*rm*n" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 22 02:19:33 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LlCLc-0007Gt-O4 for ged-emacs-devel@m.gmane.org; Sun, 22 Mar 2009 02:19:32 +0100 Original-Received: from localhost ([127.0.0.1]:45461 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LlCKG-0006cb-21 for ged-emacs-devel@m.gmane.org; Sat, 21 Mar 2009 21:18:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LlCKB-0006cW-GI for emacs-devel@gnu.org; Sat, 21 Mar 2009 21:18:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LlCK6-0006cK-69 for emacs-devel@gnu.org; Sat, 21 Mar 2009 21:18:02 -0400 Original-Received: from [199.232.76.173] (port=50146 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LlCK5-0006cH-Ut for emacs-devel@gnu.org; Sat, 21 Mar 2009 21:17:57 -0400 Original-Received: from ironport2-out.pppoe.ca ([206.248.154.182]:4179 helo=ironport2-out.teksavvy.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LlCK5-0005vm-Nd for emacs-devel@gnu.org; Sat, 21 Mar 2009 21:17:57 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjoFAOIuxUlFxIZP/2dsb2JhbACBTNImg34GhGc X-IronPort-AV: E=Sophos;i="4.38,401,1233550800"; d="scan'208";a="35490593" Original-Received: from 69-196-134-79.dsl.teksavvy.com (HELO pastel.home) ([69.196.134.79]) by ironport2-out.teksavvy.com with ESMTP; 21 Mar 2009 21:17:53 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 170A97F74; Sat, 21 Mar 2009 21:18:15 -0400 (EDT) In-Reply-To: (S.'s message of "Sat, 21 Mar 2009 21:01:14 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109768 Archived-At: > The var `url-get-url-filename-chars' is bound globally to > "-%.?@a-zA-Z0-9()_/:~=&" > and called by `url-get-url-at-point' in ../lisp/url/url-util.el > Why isn't comma (",") defined as a valid URL character? url-get-url-filename-chars doesn't actually define valid URL chars (contrary to what its docstring claim), only chars that are likely to be included in URLs that appear in the middle of other chunks of text, and that are unlikely to be part of the surrounding text. > (FWIW I seem to be encountering comma's in web URLs with increasing > frequency). It's likely that url-get-url-at-point will need to be updated if that's indeed becoming the norm. E.g. we already allow "." and then filter it out if it appears as the last element. We could do the same for ",". Stefan