all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: David Reitter <david.reitter@gmail.com>
Cc: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: vc-git: workaround for "file unregistered" problem
Date: Thu, 12 Nov 2009 12:08:46 -0500	[thread overview]
Message-ID: <jwvpr7nu0yh.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <6095145D-CC53-45CF-8191-4B3F5A26F575@gmail.com> (David Reitter's message of "Thu, 12 Nov 2009 10:57:17 -0500")

>>> Either way, specifying full paths works around the problem, and the
>>> patch below does that for those who encounter similar issues.
>> It looks acceptable, exept that, like all patches which try to work
>> around a problem, it should come with a corresponding comment.
> If only I understood the underlying problem better!
> I will try to do more research and check this in with an appropriate comment.

The comment doesn't need to explain the problem, but it needs to explain
why the code is written the way it is (e.g. "because if we use
a relative name Git seems to sometimes return incorrect data", ideally
even with a reference to the Git bug report).


        Stefan




      reply	other threads:[~2009-11-12 17:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-12 13:44 vc-git: workaround for "file unregistered" problem David Reitter
2009-11-12 15:39 ` Stefan Monnier
2009-11-12 15:57   ` David Reitter
2009-11-12 17:08     ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvpr7nu0yh.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=david.reitter@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.