From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: `save-excursion' defeated by `set-buffer' Date: Mon, 11 Jan 2010 11:50:59 -0500 Message-ID: References: <87aaxdqwqv.fsf@regnitz.physics.niu.edu> <876380nvnt.fsf@lola.goethe.zz> <87hbrijbyg.fsf@lola.goethe.zz> <87skb0iw04.fsf@lola.goethe.zz> <1DA372296B5F41A1A3317F557D27355D@us.oracle.com> <87ocl8gvcn.fsf@lola.goethe.zz> <558DC61A9B3E4FF89CC53FF9DF7F7709@us.oracle.com> <87eim3hd14.fsf@lola.goethe.zz> <87eilyl6o9.fsf@lola.goethe.zz> <87skadjbgi.fsf@lola.goethe.zz> <4B4AEDAE.7020903@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1263228694 8312 80.91.229.12 (11 Jan 2010 16:51:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 11 Jan 2010 16:51:34 +0000 (UTC) Cc: David Kastrup , emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 11 17:51:26 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NUNU6-0003E1-7l for ged-emacs-devel@m.gmane.org; Mon, 11 Jan 2010 17:51:18 +0100 Original-Received: from localhost ([127.0.0.1]:53394 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUNU6-0008BA-Kc for ged-emacs-devel@m.gmane.org; Mon, 11 Jan 2010 11:51:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUNTx-00089k-Eh for emacs-devel@gnu.org; Mon, 11 Jan 2010 11:51:09 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUNTs-00087n-PX for emacs-devel@gnu.org; Mon, 11 Jan 2010 11:51:08 -0500 Original-Received: from [199.232.76.173] (port=34950 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUNTs-00087h-Jl for emacs-devel@gnu.org; Mon, 11 Jan 2010 11:51:04 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:39831 helo=ironport2-out.pppoe.ca) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUNTp-0000VT-3q; Mon, 11 Jan 2010 11:51:01 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArMEADvmSkvO+KPG/2dsb2JhbACBRNcihC8Eiik X-IronPort-AV: E=Sophos;i="4.49,257,1262581200"; d="scan'208";a="53516215" Original-Received: from 206-248-163-198.dsl.teksavvy.com (HELO pastel.home) ([206.248.163.198]) by ironport2-out.pppoe.ca with ESMTP; 11 Jan 2010 11:50:59 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 542D781C9; Mon, 11 Jan 2010 11:50:59 -0500 (EST) In-Reply-To: <4B4AEDAE.7020903@gmx.at> (martin rudalics's message of "Mon, 11 Jan 2010 10:21:50 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:119826 Archived-At: >> If you say that you find most (save-excursion (set-buffer combinations >> in the Emacs code base a bad idea, the solution is using grep and fixing >> all those occurences where you think they are an error. > Admittedly, there are too many occurrences of this idiom to be fixed by > a single person in reasonable time. I do have them all fixed here (only for files bundles with Emacs, obviously). > I suppose Stefan, when fixing a bug incorrectly using that idiom, > decided that the respective authors should care about the > remaining instances. No, as you may have noticed I installed a whole bunch of little patches to most of lisp/**/*.el to fix those issues. The remaining ones are in lisp/gnus. Stefan