From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] eliminate false positive in compile.el Date: Thu, 25 Mar 2010 15:24:42 -0400 Message-ID: References: <4BAAE19B.5000000@censorshipresearch.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1269550275 2859 80.91.229.12 (25 Mar 2010 20:51:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 25 Mar 2010 20:51:15 +0000 (UTC) Cc: Emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 25 21:51:09 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Nuu1B-0006So-Vd for ged-emacs-devel@m.gmane.org; Thu, 25 Mar 2010 21:51:06 +0100 Original-Received: from localhost ([127.0.0.1]:44519 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nuu1B-00033u-8B for ged-emacs-devel@m.gmane.org; Thu, 25 Mar 2010 16:51:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nusfk-0006o5-TI for emacs-devel@gnu.org; Thu, 25 Mar 2010 15:24:52 -0400 Original-Received: from [140.186.70.92] (port=43109 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nusfj-0006ng-FG for Emacs-devel@gnu.org; Thu, 25 Mar 2010 15:24:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nusfh-00073N-Df for Emacs-devel@gnu.org; Thu, 25 Mar 2010 15:24:51 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:57892) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nusfh-000734-7o for Emacs-devel@gnu.org; Thu, 25 Mar 2010 15:24:49 -0400 Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id o2PJOgHs019308; Thu, 25 Mar 2010 15:24:42 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 539633A0F4; Thu, 25 Mar 2010 15:24:42 -0400 (EDT) In-Reply-To: <4BAAE19B.5000000@censorshipresearch.org> (Daniel Colascione's message of "Thu, 25 Mar 2010 00:07:55 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3499=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:122673 Archived-At: > === modified file 'lisp/progmodes/compile.el' > - --- lisp/progmodes/compile.el 2010-03-24 13:41:07 +0000 > +++ lisp/progmodes/compile.el 2010-03-25 03:22:22 +0000 > @@ -262,7 +262,7 @@ > \\(?:-\\([0-9]+\\)?\\(?:\\.\\([0-9]+\\)\\)?\\)?:\ > \\(?: *\\(\\(?:Future\\|Runtime\\)?[Ww]arning\\|W:\\)\\|\ > *\\([Ii]nfo\\(?:\\>\\|rmationa?l?\\)\\|I:\\|instantiated > from\\|[Nn]ote\\)\\|\ > -\[0-9]?\\(?:[^0-9\n]\\|$\\)\\|[0-9][0-9][0-9]\\)" > +\[0-9]?\\(?:[^0-9\n]\\)\\|[0-9][0-9][0-9]\\)" which simplifies to \[0-9]?[^0-9\n]\\|[0-9][0-9][0-9]\\)" Could you give some rationale for this change other than just "eliminate false positive"? I mean, someone went to the trouble to add the \\(?:...\\|$\\), so there should be a good reason to remove it, Stefan