all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Jan Moringen <jan.moringen@uni-bielefeld.de>
Cc: John Wiegley <johnw@gnu.org>, emacs-devel@gnu.org
Subject: Re: eshell and after-change-functions
Date: Wed, 21 Jul 2010 17:49:41 +0200	[thread overview]
Message-ID: <jwvpqygvnus.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <27611_1279665215_ZZh045m5ysdni.00_1279665214.3039.14.camel@steed.robot-madness> (Jan Moringen's message of "Wed, 21 Jul 2010 00:33:34 +0200")

> The feature in question is sharing interactive buffers like comint,
> slime and, well, eshell with other users. The problem is that Rudel
> relies on `after-change-functions' to monitor buffer changes and
> propagate them to peers, but eshell let-binds this variable to nil in
> `eshell-send-input' and `eshell-output-filter'. This prevents buffer
> changes performed in these functions from being propagated and
> de-synchronizes the session. I cannot find a specific reason for
> disabling all after-change functions in the ehsell code and was
> wondering if somebody knows why this is necessary. If it is not
> necessary, could this maybe be changed?

Have you tried to remove the offending let-binding and see what effect
it has on Eshell's behavior?
The commit logs don't give any help about the reason for these bindings,
and looking at the code I can't figure it out myself either, so unless
John remembers why they were added, we'll be forced to just "try and
pray".


        Stefan



  reply	other threads:[~2010-07-21 15:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-20 22:33 eshell and after-change-functions Jan Moringen
2010-07-21 15:49 ` Stefan Monnier [this message]
2010-07-21 17:31   ` Jan Moringen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvpqygvnus.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=jan.moringen@uni-bielefeld.de \
    --cc=johnw@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.