From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: python.el doesn't define `comment-start-skip' Date: Mon, 15 Nov 2010 10:38:16 -0500 Message-ID: References: <51665.128.165.123.18.1231882998.squirrel@webmail.lanl.gov> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1289835526 1288 80.91.229.12 (15 Nov 2010 15:38:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 15 Nov 2010 15:38:46 +0000 (UTC) Cc: emacs-devel@gnu.org To: herring@lanl.gov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 15 16:38:31 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PI18Z-00073Z-9X for ged-emacs-devel@m.gmane.org; Mon, 15 Nov 2010 16:38:31 +0100 Original-Received: from localhost ([127.0.0.1]:45964 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PI18Y-0002vp-Q0 for ged-emacs-devel@m.gmane.org; Mon, 15 Nov 2010 10:38:30 -0500 Original-Received: from [140.186.70.92] (port=55014 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PI18R-0002kW-9P for emacs-devel@gnu.org; Mon, 15 Nov 2010 10:38:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PI18M-0007Vj-HE for emacs-devel@gnu.org; Mon, 15 Nov 2010 10:38:23 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:36067 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PI18M-0007VO-Df for emacs-devel@gnu.org; Mon, 15 Nov 2010 10:38:18 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmwHAB/j4ExFpY76/2dsb2JhbACUV40EfnK9KIVKBIRajV8 X-IronPort-AV: E=Sophos;i="4.59,200,1288584000"; d="scan'208";a="82583167" Original-Received: from 69-165-142-250.dsl.teksavvy.com (HELO pastel.home) ([69.165.142.250]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 15 Nov 2010 10:38:16 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 8F336A8263; Mon, 15 Nov 2010 10:38:16 -0500 (EST) In-Reply-To: <51665.128.165.123.18.1231882998.squirrel@webmail.lanl.gov> (Davis Herring's message of "Tue, 13 Jan 2009 13:43:18 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132633 Archived-At: > It's implied in newcomment.el that `comment-normalize-vars' should be > called before using the library, which creates `comment-start-skip' if > necessary. However, many programming modes seem to define it themselves; > cperl-mode uses "#+ *", and the old python-mode.el uses just "# *". > Should this be added? The old commenting code (i.e. before newcomment.el) did not know how to build comment-start-skip from comment-start, so many major modes set it manually. Other major modes set it manually because newcomment.el doesn't do a good enough job of guessing the value of comment-start-skip. In the case of python.el I don't think it's necessary. Stefan "going through some of his voluminous backlog"