all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: herring@lanl.gov
Cc: emacs-devel@gnu.org
Subject: Re: python.el doesn't define `comment-start-skip'
Date: Mon, 15 Nov 2010 10:38:16 -0500	[thread overview]
Message-ID: <jwvpqu6k39r.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <51665.128.165.123.18.1231882998.squirrel@webmail.lanl.gov> (Davis Herring's message of "Tue, 13 Jan 2009 13:43:18 -0800 (PST)")

> It's implied in newcomment.el that `comment-normalize-vars' should be
> called before using the library, which creates `comment-start-skip' if
> necessary.  However, many programming modes seem to define it themselves;
> cperl-mode uses "#+ *", and the old python-mode.el uses just "# *". 
> Should this be added?

The old commenting code (i.e. before newcomment.el) did not know how to
build comment-start-skip from comment-start, so many major modes set
it manually.  Other major modes set it manually because newcomment.el
doesn't do a good enough job of guessing the value of
comment-start-skip.
In the case of python.el I don't think it's necessary.


        Stefan "going through some of his voluminous backlog"



      reply	other threads:[~2010-11-15 15:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-13 21:43 python.el doesn't define `comment-start-skip' Davis Herring
2010-11-15 15:38 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvpqu6k39r.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=herring@lanl.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.