From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#7473: 24.0.50; `diff' command broken Date: Wed, 24 Nov 2010 23:45:42 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1290662096 3918 80.91.229.12 (25 Nov 2010 05:14:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 25 Nov 2010 05:14:56 +0000 (UTC) To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 25 06:14:49 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PLUAS-0005xm-RZ for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Nov 2010 06:14:49 +0100 Original-Received: from localhost ([127.0.0.1]:52101 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLUAR-0005wE-9z for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Nov 2010 00:14:47 -0500 Original-Received: from [140.186.70.92] (port=45802 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLUAN-0005uy-9J for bug-gnu-emacs@gnu.org; Thu, 25 Nov 2010 00:14:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLUAM-0000qj-1U for bug-gnu-emacs@gnu.org; Thu, 25 Nov 2010 00:14:43 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLUAL-0000qb-VA for bug-gnu-emacs@gnu.org; Thu, 25 Nov 2010 00:14:42 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PLTnS-0004Ov-G1 for bug-gnu-emacs@gnu.org; Wed, 24 Nov 2010 23:51:02 -0500 Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Nov 2010 04:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 7473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 7473@debbugs.gnu.org, monnier@IRO.UMontreal.CA Original-Received: via spool by 7473-done@debbugs.gnu.org id=D7473.129066062716875 (code D ref 7473); Thu, 25 Nov 2010 04:51:02 +0000 Original-Received: (at 7473-done) by debbugs.gnu.org; 25 Nov 2010 04:50:27 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PLTms-0004O7-4D for submit@debbugs.gnu.org; Wed, 24 Nov 2010 23:50:26 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PLTd9-0004Ab-7L for 7473-done@debbugs.gnu.org; Wed, 24 Nov 2010 23:40:24 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id oAP4jhGR006314; Wed, 24 Nov 2010 23:45:43 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id B018EA867F; Wed, 24 Nov 2010 23:45:42 -0500 (EST) In-Reply-To: (Glenn Morris's message of "Wed, 24 Nov 2010 14:29:39 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3689=0 X-Mailman-Approved-At: Wed, 24 Nov 2010 23:50:24 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 24 Nov 2010 23:51:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41885 Archived-At: >> 1) M-x diff >> >> After that, the minibuffer shows the error message: `Symbol's value as >> variable is void: newf'. > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7277#13 Thanks, indeed, should be fixed now, Stefan === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2010-11-24 16:39:51 +0000 +++ lisp/ChangeLog 2010-11-25 04:43:30 +0000 @@ -1,3 +1,7 @@ +2010-11-25 Stefan Monnier + + * vc/diff.el (diff): Fix last change. + 2010-11-24 Stefan Monnier * emacs-lisp/pcase.el: Improve pcase-let. Use "pcase--" prefix. === modified file 'lisp/vc/diff.el' --- lisp/vc/diff.el 2010-11-22 19:22:03 +0000 +++ lisp/vc/diff.el 2010-11-25 04:28:25 +0000 @@ -84,7 +84,7 @@ interactively for diff switches. Otherwise, the switches specified in `diff-switches' are passed to the diff command." (interactive - (let ((newf (buffer-file-name)) + (let* ((newf (buffer-file-name)) (oldf (file-newest-backup newf))) (setq newf (if (and newf (file-exists-p newf)) (read-file-name