all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Leo <sdl.web@gmail.com>
Cc: 5937@debbugs.gnu.org
Subject: bug#5937: 23.1.95; why saving empty abbrev tables
Date: Mon, 28 Mar 2011 23:31:13 -0400	[thread overview]
Message-ID: <jwvpqpa7gog.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m1aage4vcl.fsf@gmail.com> (Leo's message of "Tue, 29 Mar 2011 08:35:22 +0800")

>> I'd rather call edit-abbrevs-redefine from the new command you'll bind
>> to C-x C-w.
> Do you mean 'C-x C-s'? C-x C-w is bound to write-abbrev-file in the
> patch? If so, I guess it makes sense not to bind C-x C-w.

Oh, I didn't notice this part of the patch.  So I guess what I'm
suggesting is to create a new command for use in C-x C-w which calls
edit-abbrevs-redefine and then calls interactively write-abbrev-file.
The issue with write-abbrev-file is that it's called from
save-some-buffers so we can't/shouldn't bind it to edit-abbrevs.

Maybe another solution is to change edit-abbrevs-mode so that
save-buffer and write-file work in it by calling internally
write-abbrev-file.  Note sure if that can be made to work without major
surgery, tho (write-region-annotate-functions could do some of it, but
I think the lack of buffer-file-name setting will get in the way, so
we'd have to change edit-abbrevs so that it sets buffer-file-name and
is really turned into a major mode to edit the .abbrev-defs file, which
seems like a fairly different beast).


        Stefan





  reply	other threads:[~2011-03-29  3:31 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-12 15:23 bug#5937: 23.1.95; why saving empty abbrev tables Leo
2010-04-12 18:32 ` Stefan Monnier
2010-04-15 10:26   ` Leo
2010-04-15 12:44     ` Stefan Monnier
2010-04-16 10:36   ` Leo
2010-04-27  3:49     ` Stefan Monnier
2010-04-27  8:46       ` Leo
2010-04-27 10:12         ` Leo
2010-04-27 10:32         ` Leo
2011-03-27 20:40           ` Stefan Monnier
2011-03-28  4:45             ` Leo
2011-03-28 13:58               ` Stefan Monnier
2011-03-28 14:26                 ` Leo
2011-03-28 15:09                   ` Stefan Monnier
2011-03-29  0:35                     ` Leo
2011-03-29  3:31                       ` Stefan Monnier [this message]
2011-03-29  4:41                         ` Leo
2011-03-29  5:16                           ` Leo
2011-03-29 13:49                             ` Stefan Monnier
2011-03-29 15:42                               ` Leo
2011-03-29 20:54                                 ` Stefan Monnier
2011-03-30  1:08                                   ` Leo
2011-03-27  5:09       ` Leo
2011-03-27 17:34         ` Andreas Röhler
2011-03-28  3:38           ` Leo
2011-03-27 20:35         ` Stefan Monnier
2011-03-28  4:03           ` Leo
2011-03-28 14:02             ` Stefan Monnier
2011-03-28 14:40               ` Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvpqpa7gog.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=5937@debbugs.gnu.org \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.