From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.eieio,gmane.emacs.devel Subject: Re: Cleaning up the EIEIO namespace Date: Tue, 12 Feb 2013 21:47:51 -0500 Message-ID: References: <87sj51fakd.fsf@engster.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1360723679 11257 80.91.229.3 (13 Feb 2013 02:47:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Feb 2013 02:47:59 +0000 (UTC) Cc: "Eric M. Ludlam" , emacs-devel@gnu.org To: cedet-eieio@lists.sourceforge.net Original-X-From: cedet-eieio-bounces@lists.sourceforge.net Wed Feb 13 03:48:20 2013 Return-path: Envelope-to: sf-cedet-eieio@m.gmane.org Original-Received: from lists.sourceforge.net ([216.34.181.88]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U5SOS-0005L9-CB for sf-cedet-eieio@m.gmane.org; Wed, 13 Feb 2013 03:48:20 +0100 Original-Received: from localhost ([127.0.0.1] helo=sfs-ml-4.v29.ch3.sourceforge.com) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1U5SO7-0001uv-R7; Wed, 13 Feb 2013 02:47:59 +0000 Original-Received: from sog-mx-1.v43.ch3.sourceforge.com ([172.29.43.191] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1U5SO6-0001uq-F9 for cedet-eieio@lists.sourceforge.net; Wed, 13 Feb 2013 02:47:58 +0000 Received-SPF: softfail (sog-mx-1.v43.ch3.sourceforge.com: transitioning domain of iro.umontreal.ca does not designate 206.248.154.182 as permitted sender) client-ip=206.248.154.182; envelope-from=monnier@iro.umontreal.ca; helo=ironport2-out.teksavvy.com; Original-Received: from [206.248.154.182] (helo=ironport2-out.teksavvy.com) by sog-mx-1.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1U5SO5-0000dF-M2 for cedet-eieio@lists.sourceforge.net; Wed, 13 Feb 2013 02:47:58 +0000 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFpYjU/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA2IQgaxH5AOjWGDKQOIYZwZgV6DFQ X-IPAS-Result: Av4EABK/CFFFpYjU/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA2IQgaxH5AOjWGDKQOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="1131560" Original-Received: from 69-165-136-212.dsl.teksavvy.com (HELO pastel.home) ([69.165.136.212]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 12 Feb 2013 21:47:51 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id A760959267; Tue, 12 Feb 2013 21:47:51 -0500 (EST) In-Reply-To: <87sj51fakd.fsf@engster.org> (David Engster's message of "Tue, 12 Feb 2013 23:10:10 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Spam-Score: 2.0 (++) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 1.0 RDNS_NONE Delivered to internal network by a host with no rDNS X-Headers-End: 1U5SO5-0000dF-M2 X-BeenThere: cedet-eieio@lists.sourceforge.net X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: cedet-eieio-bounces@lists.sourceforge.net Xref: news.gmane.org gmane.emacs.eieio:132 gmane.emacs.devel:156995 Archived-At: >> Here is a patch that attempts to clean up part of the EIEIO namespace. >> If you like it, please install it upstream, so it will get merged into >> Emacs later on. If you prefer, I can install it into Emacs directly and >> you'll merge it later on upstream, of course. > Thank you for the patch. I know it cannot have been fun. :-) It was largely mechanical, tho. > I didn't have time yet to look at your patch in detail. I did apply it > to CEDET trunk and got byte-compile errors because there's > eieio-class-parent as well as eieio--class-parent. Hmm.. there are both eieio-class-parent as well as eieio--class-parent, but I'm not sure why that would cause a byte-compile error. > As for the general direction of the cleanup: We did discuss this a bit > in the bug report you opened for it some time ago, and Eric stated that > he'd at least like to keep the CLOS-compatible names without having to > prefix everything with 'eieio-'. Your suggestion was to use the shorter > 'cl-' prefix instead, and at least I think that is a good compromise. So > instead of using 'eieio-class-name', for instance, we'd rather use > 'cl-class-name'. I don't know enough CLOS to see which other names are > affected by this (but I could easily look it up, of course). I don't know CLOS either. I also don't know EIEIO enough to know for sure which functions are "internal" (and can hence move to "eieio-" or even "eieio--" without any problem) and which are "exported", so that renaming them has to be done more carefully (with obsolete aliases). > Regarding the merge procedure: I'm a bit hesitant to merge the current > CEDET trunk to Emacs just yet because the Java-support is pretty much in > flux right now, so I'd prefer if you just apply it in Emacs trunk. OK. > We were planning to move EIEIO development to Emacs trunk anyway. I'm > actually hoping that we can remove EIEIO from CEDET upstream some time > later this year. Sounds good, Stefan ------------------------------------------------------------------------------ Free Next-Gen Firewall Hardware Offer Buy your Sophos next-gen firewall before the end March 2013 and get the hardware for free! Learn more. http://p.sf.net/sfu/sophos-d2d-feb