From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Reuben Thomas <rrt@sc3d.org>
Cc: 13837@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#13837: 24.2; Make it possible to turn whitespace-mode only when there are no existing problems
Date: Mon, 27 Jan 2014 10:00:30 -0500 [thread overview]
Message-ID: <jwvppndfp63.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <CAOnWdojYcgA0HS-iccfA7E0B5x3QMZG_wHJMjzmheN2edsZNzQ@mail.gmail.com> (Reuben Thomas's message of "Mon, 27 Jan 2014 13:25:01 +0000")
>> But it's not obviously safe to me. Two non-obvious parts are:
>> - the removal of "(add-to-list 'whitespace-style (car option))".
> The removal looks wrong to me too: without that code, the force argument
> has no effect. On the other hand, the way it's implemented also seems
> wrong, as it permanently changes whitespace-style.
Agreed on both aspects.
>> - the change from has-bogus to bogus-list, where bogus-list will
>> (initially) only be nil if whitespace-report-list is nil.
> As far as I can see, has-bogus was set whenever an element was added to
> bogus-list.
The way I read the code bogus-list is a list of booleans (either nil or
t), returned by `mapcar', so it has as many elements as
whitespace-report-list. IOW an element was/is added to bogus-list
regardless if a test succeeds/fails.
> 1. I would like to refactor the description of whitespace problems in
> whitespace-report-region to move those which are the same regardless of the
> value of indent-tabs-mode into a separate list.
Fine.
> 2. Since we're no longer going for getting this into 24.4, can we fold your
> "artificial" whitespace--report-report-region back into
> whitespace-report-region, which both simplifies the end result slightly,
> and avoids the question of whether the new function should be moved down
> into "internal functions"?
Of course,
Stefan
next prev parent reply other threads:[~2014-01-27 15:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 21:41 bug#13837: 24.2; Make it possible to turn whitespace-mode only when there are no existing problems Reuben Thomas
2013-02-28 2:00 ` bug#13837: Update to code Reuben Thomas
2013-02-28 16:23 ` bug#13837: 24.2; Make it possible to turn whitespace-mode only when there are no existing problems Stefan Monnier
2013-02-28 16:32 ` Stefan Monnier
2013-03-01 22:02 ` Reuben Thomas
2013-03-02 3:02 ` Stefan Monnier
2013-03-02 7:46 ` Reuben Thomas
2013-03-03 23:36 ` Stefan Monnier
2013-03-01 22:21 ` Reuben Thomas
2013-03-02 3:01 ` Stefan Monnier
2013-03-02 7:49 ` Reuben Thomas
2013-04-10 0:50 ` Reuben Thomas
2013-10-17 23:09 ` Reuben Thomas
2014-01-26 23:12 ` Reuben Thomas
2014-01-26 23:29 ` Dmitry Gutov
2014-01-26 23:31 ` Reuben Thomas
2014-01-27 0:27 ` Dmitry Gutov
2014-01-27 0:41 ` Reuben Thomas
2014-01-27 1:52 ` Stefan Monnier
2014-01-27 13:25 ` Reuben Thomas
2014-01-27 15:00 ` Stefan Monnier [this message]
2014-01-27 21:19 ` Reuben Thomas
2014-01-28 0:32 ` Stefan Monnier
2014-01-28 0:48 ` Reuben Thomas
2014-05-29 17:26 ` Stefan Monnier
2014-05-29 19:01 ` Reuben Thomas
2014-05-29 20:28 ` Stefan Monnier
2014-05-29 22:53 ` Reuben Thomas
2014-05-30 2:01 ` Glenn Morris
2014-05-29 19:02 ` Reuben Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvppndfp63.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=13837@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=rrt@sc3d.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.