From: Stefan Monnier <monnier@iro.umontreal.ca>
To: help-gnu-emacs@gnu.org
Subject: Re: Reporting when keymapping stomped... best approach
Date: Tue, 10 Jun 2014 15:24:02 -0400 [thread overview]
Message-ID: <jwvppigh8ps.fsf-monnier+gmane.emacs.help@gnu.org> (raw)
In-Reply-To: CAAjq1mccAwa42MRcWpRVpdyUFPz-JmzrUM6Ki1pboBePEz5LSw@mail.gmail.com
> (defadvice global-set-key (before check-keymapping activate)
> (let ((key (ad-get-arg 0))
> (command (ad-get-arg 1)))
> (when command
> (warn (concat "Just stomped on a global keymapping bound to: "
> command)))))
This doesn't check whether the key was already bound.
You'll probably prefer something like
(defadvice global-set-key (before check-keymapping activate)
(let* ((key (ad-get-arg 0))
(command (ad-get-arg 1))
(old (lookup-key global-map key)))
(when old
(message "Replacing %S with %S in global-map"
old command))))
and you'll probably also want to advise `define-key' similarly.
Stefan
next prev parent reply other threads:[~2014-06-10 19:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-10 19:15 Reporting when keymapping stomped... best approach Grant Rettke
2014-06-10 19:24 ` Stefan Monnier [this message]
2014-06-10 23:56 ` Grant Rettke
2014-06-12 6:50 ` Kevin Rodgers
2014-06-12 17:18 ` Grant Rettke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvppigh8ps.fsf-monnier+gmane.emacs.help@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=help-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.