all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dani Moncayo <dmoncayo@gmail.com>
Cc: 17984-done@debbugs.gnu.org
Subject: bug#17984: 24.4.50; Error in post-command-hook (rectangle--string-preview)
Date: Fri, 18 Jul 2014 21:44:10 -0400	[thread overview]
Message-ID: <jwvpph215tn.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <CAH8Pv0gKTU-kbhaGgAoCT=qc=Z81pzExHayQMeZ+1-+5Gmd38w@mail.gmail.com> (Dani Moncayo's message of "Thu, 10 Jul 2014 09:05:08 +0200")

> emacs -Q
> Select a couple of lines.
> C-x r t
> At that moment, I see this error in the echo area:
>   Error in post-command-hook (rectangle--string-preview):
> (wrong-type-argument stringp nil)

Indeed, thanks.  I installed the patch below which should fix this
problem,


        Stefan


=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog	2014-07-16 17:06:12 +0000
+++ lisp/ChangeLog	2014-07-19 01:43:04 +0000
@@ -1,3 +1,8 @@
+2014-07-19  Stefan Monnier  <monnier@iro.umontreal.ca>
+
+	* rect.el (rectangle--string-preview): Don't assume there
+	a non-nil default (bug#17984).
+
 2014-07-16  Glenn Morris  <rgm@gnu.org>
 
 	* desktop.el (after-init-hook): Disable startup frame restoration

=== modified file 'lisp/rect.el'
--- lisp/rect.el	2014-07-09 02:20:21 +0000
+++ lisp/rect.el	2014-07-19 01:41:57 +0000
@@ -396,7 +396,7 @@
     (when (equal str "")
       (setq str (or (car-safe minibuffer-default)
                     (if (stringp minibuffer-default) minibuffer-default))))
-    (setq str (propertize str 'face 'region))
+    (when str (setq str (propertize str 'face 'region)))
     (with-selected-window rectangle--string-preview-window
       (unless (or (null rectangle--string-preview-state)
                   (equal str (car rectangle--string-preview-state)))






      reply	other threads:[~2014-07-19  1:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-10  7:05 bug#17984: 24.4.50; Error in post-command-hook (rectangle--string-preview) Dani Moncayo
2014-07-19  1:44 ` Stefan Monnier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvpph215tn.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=17984-done@debbugs.gnu.org \
    --cc=dmoncayo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.