From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] files.el: avoid asking whether to kill Emacs multiple times Date: Thu, 29 Jan 2015 10:54:42 -0500 Message-ID: References: <1422540409-4134-1-git-send-email-mpn@google.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1422546933 29440 80.91.229.3 (29 Jan 2015 15:55:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 29 Jan 2015 15:55:33 +0000 (UTC) Cc: Michal Nazarewicz , emacs-devel@gnu.org To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 29 16:55:33 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YGrRK-0004R0-8O for ged-emacs-devel@m.gmane.org; Thu, 29 Jan 2015 16:55:30 +0100 Original-Received: from localhost ([::1]:60494 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGrRJ-0002Na-92 for ged-emacs-devel@m.gmane.org; Thu, 29 Jan 2015 10:55:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGrQf-0001Yx-1s for emacs-devel@gnu.org; Thu, 29 Jan 2015 10:54:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGrQb-0000We-Sd for emacs-devel@gnu.org; Thu, 29 Jan 2015 10:54:49 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:52443) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGrQb-0000WA-Om for emacs-devel@gnu.org; Thu, 29 Jan 2015 10:54:45 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id t0TFsgXx025343; Thu, 29 Jan 2015 10:54:43 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id CA4402214; Thu, 29 Jan 2015 10:54:42 -0500 (EST) In-Reply-To: (Drew Adams's message of "Thu, 29 Jan 2015 06:35:23 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.5 X-NAI-Spam-Rules: 2 Rules triggered SUBJ_HAS_SPACES=0.5, RV5201=0 X-NAI-Spam-Version: 2.3.0.9393 : core <5201> : inlines <1988> : streams <1381419> : uri <1844285> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:181986 Archived-At: >> If `confirm-kill-emacs' is set, but user has just been asked whether >> they really want to kill Emacs (for example with a =E2=80=98Modified buf= fers >> exist; exit anyway?=E2=80=99 prompt), do not ask them for another confir= mation. I agree that skipping the second confirmation would be desirable. >> However, apply this exception only if `confirm-kill-emacs' is >> 'yes-or-no-p or 'y-or-n-p, otherwise this change might errenously >> prevent some user defined function from being run. Is it really worth the trouble? Comparing functions is just a bad idea in general, so if we can avoid it, it's preferable. > Related? > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D9577 Another painful one is when a file is modified outside of Emacs but you still want to edit the current buffer and then save it (hence overwriting the changes made outside of Emacs). I think in total this gets you 3 confirmation prompts and at least one of them should go. Stefan