all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Drew Adams <drew.adams@oracle.com>
Cc: Michal Nazarewicz <mpn@google.com>, emacs-devel@gnu.org
Subject: Re: [PATCH] files.el: avoid asking whether to kill Emacs multiple times
Date: Thu, 29 Jan 2015 10:54:42 -0500	[thread overview]
Message-ID: <jwvpp9xegd3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <cabe2b14-f6ab-48bb-8cf9-8d667b8a522d@default> (Drew Adams's message of "Thu, 29 Jan 2015 06:35:23 -0800 (PST)")

>> If `confirm-kill-emacs' is set, but user has just been asked whether
>> they really want to kill Emacs (for example with a ‘Modified buffers
>> exist; exit anyway?’ prompt), do not ask them for another confirmation.

I agree that skipping the second confirmation would be desirable.

>> However, apply this exception only if `confirm-kill-emacs' is
>> 'yes-or-no-p or 'y-or-n-p, otherwise this change might errenously
>> prevent some user defined function from being run.

Is it really worth the trouble?  Comparing functions is just a bad idea
in general, so if we can avoid it, it's preferable.

> Related?
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9577

Another painful one is when a file is modified outside of Emacs but you
still want to edit the current buffer and then save it (hence
overwriting the changes made outside of Emacs).  I think in total this
gets you 3 confirmation prompts and at least one of them should go.


        Stefan



  reply	other threads:[~2015-01-29 15:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-29 14:06 [PATCH] files.el: avoid asking whether to kill Emacs multiple times Michal Nazarewicz
2015-01-29 14:35 ` Drew Adams
2015-01-29 15:54   ` Stefan Monnier [this message]
2015-01-29 16:01     ` David Kastrup
2015-01-30  1:39     ` [PATCHv2] " Michal Nazarewicz
2015-01-30  6:11       ` Stefan Monnier
2015-01-30 10:43         ` Michal Nazarewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvpp9xegd3.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    --cc=mpn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.