From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#20276: 24.4; diff-mode doesn't handle unified diff file headers without tabs Date: Wed, 08 Apr 2015 16:50:06 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1428526286 24483 80.91.229.3 (8 Apr 2015 20:51:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 Apr 2015 20:51:26 +0000 (UTC) Cc: 20276@debbugs.gnu.org To: Gustav =?UTF-8?Q?H=C3=A5llberg?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 08 22:51:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YfwwI-0000RW-AT for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Apr 2015 22:51:10 +0200 Original-Received: from localhost ([::1]:54825 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfwwH-0003xM-Dg for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Apr 2015 16:51:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfwwD-0003xD-CD for bug-gnu-emacs@gnu.org; Wed, 08 Apr 2015 16:51:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YfwwA-0004Eo-72 for bug-gnu-emacs@gnu.org; Wed, 08 Apr 2015 16:51:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YfwwA-0004Ej-4k for bug-gnu-emacs@gnu.org; Wed, 08 Apr 2015 16:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Yfww9-0004Ls-MU for bug-gnu-emacs@gnu.org; Wed, 08 Apr 2015 16:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Apr 2015 20:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20276 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20276-submit@debbugs.gnu.org id=B20276.142852623816699 (code B ref 20276); Wed, 08 Apr 2015 20:51:01 +0000 Original-Received: (at 20276) by debbugs.gnu.org; 8 Apr 2015 20:50:38 +0000 Original-Received: from localhost ([127.0.0.1]:49565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yfwvm-0004LH-2D for submit@debbugs.gnu.org; Wed, 08 Apr 2015 16:50:38 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:33158) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Yfwvi-0004L8-VA for 20276@debbugs.gnu.org; Wed, 08 Apr 2015 16:50:35 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 88D169C128; Wed, 8 Apr 2015 16:50:34 -0400 (EDT) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 8FE531E5B8C; Wed, 8 Apr 2015 16:50:06 -0400 (EDT) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 73644B4122; Wed, 8 Apr 2015 16:50:06 -0400 (EDT) In-Reply-To: ("Gustav =?UTF-8?Q?H=C3=A5llberg?="'s message of "Wed, 8 Apr 2015 00:34:23 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:101306 Archived-At: > Some diff programs will not emit tab + timestamp (as GNU diff does), > but just the file name. Which diff programs do that? > - (if (looking-at "[-*][-*][-*] \\([^\t]+\\)\t.*\n[-+][-+][-+] > \\([^\t]+\\)") > + (if (looking-at "[-*][-*][-*] \\([^\t\n]+\\).*\n[-+][-+][-+] > \\([^\t\n]+\\)") Adding \n in the char-ranges is fine (it's a good change in itself), but removing the \t increases the risk of false positives, so I'm a bit worried about that. Stefan